Implement embedded `youki` OCI gateway launcher #117

New issue

Closed

opened 2026-05-06 11:57:45 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-06 11:57:45 -07:00

Owner

Follow-up implementation slice from #115.

Decision context

The accepted sandbox ADR will make OCI isolation the default for auto-review gateway. The host process should act as an outer launcher and run the real gateway as an inner process inside an embedded youki/OCI runtime boundary.

Scope

Add the outer-launcher/inner-gateway architecture for auto-review gateway.
Embed or link the required youki runtime capability so operators do not install a separate youki executable.
Make OCI isolation the default gateway startup mode.
Add an explicit opt-out for bare-process gateway mode.
Fail closed when OCI setup fails and the operator has not opted out.
Preserve existing application-level controls: no repo-controlled execution, hermetic Git, path confinement, caps, HMAC/CI auth, and secret redaction.

Acceptance criteria

Default auto-review gateway launches the inner gateway through the embedded OCI runtime path on supported Linux hosts.
Bare mode requires an explicit opt-out flag/env var and emits prominent warnings.
OCI setup failures stop startup unless bare mode was explicitly requested.
Rootless behavior, cgroup requirements, bind mounts, port binding, state paths, and cleanup semantics are documented in code/tests.

Required tests

Focused tests for default/fail-closed/explicit-bare decision logic.
Integration or harness tests for OCI launch success/failure where feasible under Nix/CI constraints.
Regression tests that secrets do not appear in launcher diagnostics.

Follow-up implementation slice from #115. ## Decision context The accepted sandbox ADR will make OCI isolation the default for `auto-review gateway`. The host process should act as an outer launcher and run the real gateway as an inner process inside an embedded `youki`/OCI runtime boundary. ## Scope - Add the outer-launcher/inner-gateway architecture for `auto-review gateway`. - Embed or link the required `youki` runtime capability so operators do not install a separate `youki` executable. - Make OCI isolation the default gateway startup mode. - Add an explicit opt-out for bare-process gateway mode. - Fail closed when OCI setup fails and the operator has not opted out. - Preserve existing application-level controls: no repo-controlled execution, hermetic Git, path confinement, caps, HMAC/CI auth, and secret redaction. ## Acceptance criteria - Default `auto-review gateway` launches the inner gateway through the embedded OCI runtime path on supported Linux hosts. - Bare mode requires an explicit opt-out flag/env var and emits prominent warnings. - OCI setup failures stop startup unless bare mode was explicitly requested. - Rootless behavior, cgroup requirements, bind mounts, port binding, state paths, and cleanup semantics are documented in code/tests. ## Required tests - Focused tests for default/fail-closed/explicit-bare decision logic. - Integration or harness tests for OCI launch success/failure where feasible under Nix/CI constraints. - Regression tests that secrets do not appear in launcher diagnostics.

jwilger added a new dependency

2026-05-06 12:14:05 -07:00

#118 Build embedded minimal OCI rootfs for auto-review gateway

jwilger added a new dependency

2026-05-06 12:14:06 -07:00

#122 Report runtime isolation posture in gateway and CLI diagnostics

jwilger added this to the 1.0 milestone

2026-05-06 12:17:50 -07:00

jwilger referenced this issue from a pull request that will close it,

2026-05-06 14:52:03 -07:00

feat(gateway): add fail-closed OCI launcher seam #127

jwilger referenced this issue from a commit