Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(release): install publish workflow tools #200

Merged
jwilger merged 2 commits from fix-release-publish-install-tools into main 2026-05-14 14:30:12 -07:00
Conversation 1 Commits 2 Files changed 2 +59
jwilger commented 2026-05-14 13:58:38 -07:00
Owner
Copy link

Summary

  • install trusted Nix profile publication tools before release-publish resolves fixed /nix profile paths
  • add a release tooling contract test for the required pre-resolution tool install

Verification

  • bash tests/release_tooling/publish_workflow_test.sh
  • bash tests/release_tooling_test.sh
## Summary - install trusted Nix profile publication tools before release-publish resolves fixed /nix profile paths - add a release tooling contract test for the required pre-resolution tool install ## Verification - `bash tests/release_tooling/publish_workflow_test.sh` - `bash tests/release_tooling_test.sh`
fix(release): install publish workflow tools
Some checks failed
CI / Verify PR with nix flake check (pull_request) Has been cancelled
Details
CI / Build PR artifacts (no token) (pull_request) Has been cancelled
Details
CI / Publish PR artifact packages (pull_request) Has been cancelled
Details
CI / Request auto_review semantic review (pull_request) Has been cancelled
Details
91d245a796
Merge branch 'main' into fix-release-publish-install-tools
All checks were successful
CI / Verify PR with nix flake check (pull_request) Successful in 3m32s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
CI / Publish PR artifact packages (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
3621ad8c52
auto-review approved these changes 2026-05-14 14:03:29 -07:00
auto-review left a comment
Copy link

This PR updates the release-publish workflow to install necessary tools using Nix before resolving fixed paths, and adds a test to verify this behavior. The changes appear safe to merge, with improvements in workflow reliability and test coverage.

Walkthrough

  • .forgejo/workflows/release-publish.yml:
    • Added a step to install necessary tools using Nix before resolving fixed paths, ensuring that all required tools are available for the release process.
  • tests/release_tooling/publish_workflow_test.sh:
    • Added a new test to verify that the release publication tools are installed before resolving their paths, ensuring the workflow's correctness.
This PR updates the release-publish workflow to install necessary tools using Nix before resolving fixed paths, and adds a test to verify this behavior. The changes appear safe to merge, with improvements in workflow reliability and test coverage. ## Walkthrough - **.forgejo/workflows/release-publish.yml**: - Added a step to install necessary tools using Nix before resolving fixed paths, ensuring that all required tools are available for the release process. - **tests/release_tooling/publish_workflow_test.sh**: - Added a new test to verify that the release publication tools are installed before resolving their paths, ensuring the workflow's correctness.
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!200
No description provided.