Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(release): use structured PR lookup JSON #211

Merged
jwilger merged 1 commit from fix/release-prep-jq-parse into main 2026-05-16 07:41:43 -07:00
Conversation 1 Commits 1 Files changed 2 +59 -9
jwilger commented 2026-05-15 22:38:01 -07:00
Owner
Copy link

Summary

  • Replace raw release-prep pulls API lookup with tea pr ls --output json before jq parsing.
  • Add release tooling coverage to prevent raw API text from reaching jq during open release PR discovery.

Tests

  • rtk nix develop --command bash tests/release_tooling_test.sh
  • rtk nix flake check
## Summary - Replace raw release-prep pulls API lookup with `tea pr ls --output json` before jq parsing. - Add release tooling coverage to prevent raw API text from reaching jq during open release PR discovery. ## Tests - `rtk nix develop --command bash tests/release_tooling_test.sh` - `rtk nix flake check`
fix(release): use structured PR lookup JSON
All checks were successful
CI / Verify PR with nix flake check (pull_request) Successful in 3m23s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
CI / Publish PR artifact packages (pull_request) Successful in 1s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
b4169f7f0e
 
Avoid feeding raw tea API output into jq during release prep by using tea's structured PR list JSON for open release PR discovery.
auto-review approved these changes 2026-05-16 07:41:31 -07:00
auto-review left a comment
Copy link

The PR replaces raw API calls with structured JSON output for PR lookup, improving the release preparation workflow. The changes appear safe to merge, with tests updated to reflect the new logic.

Walkthrough

  • .forgejo/workflows/release-prepare.yml:
    • Replaced raw API calls with tea pr ls for structured JSON output.
    • Updated jq parsing logic to match the new JSON structure.
  • tests/release_tooling/prepare_workflow_test.sh:
    • Added checks to ensure the workflow uses structured PR listing.
    • Verified that raw API calls are no longer used in the workflow.
The PR replaces raw API calls with structured JSON output for PR lookup, improving the release preparation workflow. The changes appear safe to merge, with tests updated to reflect the new logic. ## Walkthrough - **.forgejo/workflows/release-prepare.yml**: - Replaced raw API calls with `tea pr ls` for structured JSON output. - Updated jq parsing logic to match the new JSON structure. - **tests/release_tooling/prepare_workflow_test.sh**: - Added checks to ensure the workflow uses structured PR listing. - Verified that raw API calls are no longer used in the workflow.
jwilger deleted branch fix/release-prep-jq-parse 2026-05-16 07:41:43 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!211
No description provided.