Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(ci): stop publishing PR packages #232

Merged
jwilger merged 1 commit from fix/ci-no-forgejo-packages into main 2026-05-17 10:27:59 -07:00
Conversation 1 Commits 1 Files changed 3 +10 -179
jwilger commented 2026-05-17 10:21:46 -07:00
Owner
Copy link

Summary

  • remove the release-PR Forgejo generic package publication job from CI
  • keep release PR binaries as workflow artifacts only
  • rebuild final release assets from the trusted merged commit instead of downloading release-candidate generic packages
  • update release PR wording so it no longer claims package publication

Verification

  • rtk grep -n "api/packages|generic/auto-review-pr|generic/auto-review-release-candidate|Publish PR artifact packages|pr-packages" .forgejo/workflows || true
  • actionlint .forgejo/workflows/ci.yml .forgejo/workflows/release-prepare.yml .forgejo/workflows/release-publish.yml (reports existing Forgejo/self-hosted runner/action-version warnings only: docker-release, actions/upload-artifact@v3)
## Summary - remove the release-PR Forgejo generic package publication job from CI - keep release PR binaries as workflow artifacts only - rebuild final release assets from the trusted merged commit instead of downloading release-candidate generic packages - update release PR wording so it no longer claims package publication ## Verification - `rtk grep -n "api/packages|generic/auto-review-pr|generic/auto-review-release-candidate|Publish PR artifact packages|pr-packages" .forgejo/workflows || true` - `actionlint .forgejo/workflows/ci.yml .forgejo/workflows/release-prepare.yml .forgejo/workflows/release-publish.yml` (reports existing Forgejo/self-hosted runner/action-version warnings only: `docker-release`, `actions/upload-artifact@v3`)
fix(ci): stop publishing PR packages
All checks were successful
CI / Format check (pull_request) Successful in 5s
Details
CI / Clippy (pull_request) Successful in 43s
Details
CI / Dependency policy (pull_request) Successful in 12s
Details
CI / Test (pull_request) Successful in 56s
Details
CI / Build (pull_request) Successful in 34s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: 1 warning
cb10159745
auto-review approved these changes 2026-05-17 10:27:17 -07:00
auto-review left a comment
Copy link

This PR removes the publication of release-PR packages from the CI workflow, retaining them as artifacts for review only. The final release assets are now rebuilt from the merged commit, ensuring a more secure and reliable release process. The changes appear safe to merge, but ensure all stakeholders are informed of the updated release process.

Walkthrough

  • ci.yml: Removed the pr-packages job, which previously published PR artifact packages. This aligns with the new strategy of keeping artifacts as workflow artifacts only.
  • release-prepare.yml: Updated the wording in the release PR creation to reflect that CI builds artifacts for review, not publication.
  • release-publish.yml: Adjusted the workflow to rebuild release assets from the merged commit instead of downloading them from the release-candidate packages.
This PR removes the publication of release-PR packages from the CI workflow, retaining them as artifacts for review only. The final release assets are now rebuilt from the merged commit, ensuring a more secure and reliable release process. The changes appear safe to merge, but ensure all stakeholders are informed of the updated release process. ## Walkthrough - **ci.yml**: Removed the `pr-packages` job, which previously published PR artifact packages. This aligns with the new strategy of keeping artifacts as workflow artifacts only. - **release-prepare.yml**: Updated the wording in the release PR creation to reflect that CI builds artifacts for review, not publication. - **release-publish.yml**: Adjusted the workflow to rebuild release assets from the merged commit instead of downloading them from the release-candidate packages.
.forgejo/workflows/ci.yml
auto-review commented 2026-05-17 10:27:17 -07:00
Owner
Copy link

🟡 Warning: The removal of the pr-packages job from the CI workflow is a significant change. Ensure that all stakeholders are aware of this change and that it aligns with the project's release strategy.

🟡 **Warning:** The removal of the `pr-packages` job from the CI workflow is a significant change. Ensure that all stakeholders are aware of this change and that it aligns with the project's release strategy.
jwilger marked this conversation as resolved
jwilger scheduled this pull request to auto merge when all checks succeed 2026-05-17 10:27:28 -07:00
jwilger deleted branch fix/ci-no-forgejo-packages 2026-05-17 10:27:59 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!232
No description provided.