Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(opencode): recover RGR veto delegation #235

Merged
jwilger merged 1 commit from fix/issue-233-rgr-veto-recovery into main 2026-05-17 13:14:57 -07:00
Conversation 1 Commits 1 Files changed 3 +101 -2
jwilger commented 2026-05-17 13:08:54 -07:00
Owner
Copy link

Fixes #233.

Summary

  • adds rgr_recover_implementation_review_veto to record a reviewer-veto recovery context
  • allows one rgr-test-author delegation from that recovery state when no active RGR cycle exists
  • consumes the recovery allowance after the next delegation so the normal RGR task gate remains protective

Verification

  • node --test --test-name-pattern 'allows rgr-test-author after recording implementation-review veto recovery on a dirty worktree' tests/opencode-rgr-task-gate.test.mjs
  • node --test --test-name-pattern "consumes implementation-review veto recovery after one rgr-test-author delegation" "tests/opencode-rgr-task-gate.test.mjs"
  • node --test tests/opencode-rgr-task-gate.test.mjs
  • node --test "tests/*.mjs"
  • just fmt
  • just test
Fixes #233. ## Summary - adds `rgr_recover_implementation_review_veto` to record a reviewer-veto recovery context - allows one `rgr-test-author` delegation from that recovery state when no active RGR cycle exists - consumes the recovery allowance after the next delegation so the normal RGR task gate remains protective ## Verification - `node --test --test-name-pattern 'allows rgr-test-author after recording implementation-review veto recovery on a dirty worktree' tests/opencode-rgr-task-gate.test.mjs` - `node --test --test-name-pattern "consumes implementation-review veto recovery after one rgr-test-author delegation" "tests/opencode-rgr-task-gate.test.mjs"` - `node --test tests/opencode-rgr-task-gate.test.mjs` - `node --test "tests/*.mjs"` - `just fmt` - `just test`
fix(opencode): recover RGR veto delegation
All checks were successful
CI / Format check (pull_request) Successful in 7s
Details
CI / Clippy (pull_request) Successful in 39s
Details
CI / Dependency policy (pull_request) Successful in 10s
Details
CI / Test (pull_request) Successful in 52s
Details
CI / Build (pull_request) Successful in 34s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
308cb8887a
auto-review approved these changes 2026-05-17 13:14:02 -07:00
auto-review left a comment
Copy link

The PR introduces a mechanism to handle implementation-review veto recovery, allowing a single rgr-test-author delegation when no active RGR cycle exists. The changes appear well-structured and include tests to verify the new functionality.

Walkthrough

  • auto-review-discipline.ts: Added new tools rgr_recover_implementation_review_veto and consumeImplementationReviewVetoRecovery to manage veto recovery.
  • shared.ts: Introduced a new map to track implementation-review veto recovery contexts and functions to record and consume these contexts.
  • opencode-rgr-task-gate.test.mjs: Added tests to verify that the veto recovery mechanism allows a single delegation and is consumed after use.
The PR introduces a mechanism to handle implementation-review veto recovery, allowing a single `rgr-test-author` delegation when no active RGR cycle exists. The changes appear well-structured and include tests to verify the new functionality. ## Walkthrough - **auto-review-discipline.ts**: Added new tools `rgr_recover_implementation_review_veto` and `consumeImplementationReviewVetoRecovery` to manage veto recovery. - **shared.ts**: Introduced a new map to track implementation-review veto recovery contexts and functions to record and consume these contexts. - **opencode-rgr-task-gate.test.mjs**: Added tests to verify that the veto recovery mechanism allows a single delegation and is consumed after use.
jwilger deleted branch fix/issue-233-rgr-veto-recovery 2026-05-17 13:14:57 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!235
No description provided.