fix(review): deduplicate repeated inline comments #236

Merged

jwilger merged 2 commits from fix/214-comment-deduplication into main 2026-05-17 19:20:09 -07:00

Conversation 2 Commits 2 Files changed 2 +47 -5

jwilger commented 2026-05-17 13:27:28 -07:00

Owner

Copy link

Fixes #214.

Summary

• Deduplicate mapped inline review comments by severity and message.
• Preserve the first reported location for a duplicated finding.
• Add a regression test for duplicate comments across files.

Verification

• rtk cargo test -p ar-review duplicate_severity_and_message_across_locations_posts_one_inline_comment
• just fmt
• just clippy
• just test

Fixes #214. ## Summary - Deduplicate mapped inline review comments by severity and message. - Preserve the first reported location for a duplicated finding. - Add a regression test for duplicate comments across files. ## Verification - `rtk cargo test -p ar-review duplicate_severity_and_message_across_locations_posts_one_inline_comment` - `just fmt` - `just clippy` - `just test`

jwilger added 1 commit 2026-05-17 13:27:28 -07:00

fix(review): deduplicate repeated inline comments 7f229e453b

auto-review approved these changes 2026-05-17 13:28:59 -07:00

Dismissed

auto-review left a comment

Copy link

This PR deduplicates inline review comments by severity and message, ensuring only the first occurrence is preserved. The changes include updating the output_to_review_request function and adding a regression test to verify the behavior. The modifications appear safe to merge.

Walkthrough

• crates/ar-review/src/mapping.rs:
  • Modified the output_to_review_request function to filter out duplicate findings based on severity and message.
  • Introduced a seen_findings vector to track unique findings.
• crates/ar-review/tests/review_mapping.rs:
  • Added a test duplicate_severity_and_message_across_locations_posts_one_inline_comment to ensure that duplicate findings across different locations result in only one inline comment.

This PR deduplicates inline review comments by severity and message, ensuring only the first occurrence is preserved. The changes include updating the `output_to_review_request` function and adding a regression test to verify the behavior. The modifications appear safe to merge. ## Walkthrough - **crates/ar-review/src/mapping.rs**: - Modified the `output_to_review_request` function to filter out duplicate findings based on severity and message. - Introduced a `seen_findings` vector to track unique findings. - **crates/ar-review/tests/review_mapping.rs**: - Added a test `duplicate_severity_and_message_across_locations_posts_one_inline_comment` to ensure that duplicate findings across different locations result in only one inline comment.

jwilger added 1 commit 2026-05-17 13:30:35 -07:00

Merge branch 'main' into fix/214-comment-deduplication 56114c2965

auto-review approved these changes 2026-05-17 19:19:37 -07:00

auto-review left a comment

Copy link

The PR introduces functionality to handle implementation-review veto recovery in the RGR cycle, ensuring that veto contexts are recorded and consumed correctly. The changes include new functions and tests to support this feature. The implementation appears sound, but attention should be paid to resource management and error handling.

Walkthrough

Δ since 7f229e4:

• auto-review-discipline.ts:
  • Added import statements for new functions related to veto recovery.
  • Introduced a new tool rgr_recover_implementation_review_veto to handle veto recovery.
  • Updated logic to consume veto recovery before allowing task delegation.
• shared.ts:
  • Added a map to track implementation-review veto recovery contexts.
  • Introduced functions to record and consume veto recovery.
• opencode-rgr-task-gate.test.mjs:
  • Added tests to verify the behavior of veto recovery in task delegation scenarios.
  • Introduced a helper function to create a dirty worktree for testing purposes.

The PR introduces functionality to handle implementation-review veto recovery in the RGR cycle, ensuring that veto contexts are recorded and consumed correctly. The changes include new functions and tests to support this feature. The implementation appears sound, but attention should be paid to resource management and error handling. ## Walkthrough ### Δ since 7f229e4: - **auto-review-discipline.ts**: - Added import statements for new functions related to veto recovery. - Introduced a new tool `rgr_recover_implementation_review_veto` to handle veto recovery. - Updated logic to consume veto recovery before allowing task delegation. - **shared.ts**: - Added a map to track implementation-review veto recovery contexts. - Introduced functions to record and consume veto recovery. - **opencode-rgr-task-gate.test.mjs**: - Added tests to verify the behavior of veto recovery in task delegation scenarios. - Introduced a helper function to create a dirty worktree for testing purposes.

jwilger merged commit 93731cfdf2 into main 2026-05-17 19:20:09 -07:00

jwilger deleted branch fix/214-comment-deduplication 2026-05-17 19:20:09 -07:00

jwilger referenced this pull request from a commit 2026-05-17 19:20:09 -07:00

fix(review): deduplicate repeated inline comments (#236)

Sign in to join this conversation.

Reviewers

No reviewers

auto-review

Labels

Clear labels   

bug

  

discussion

  

enhancement

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

discussion

enhancement

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Slipstream/auto_review!236

No description provided.