fix(release): keep PR selection inside Nix #240

Merged

jwilger merged 1 commit from fix/release-prepare-pr-selection into main

2026-05-17 20:46:29 -07:00

jwilger commented

2026-05-17 20:44:27 -07:00

Owner

Summary

run jq PR selection and tea close/create/edit inside one Nix shell
avoid capturing nix develop shellHook stdout (sync hooks) as PR IDs
keep API JSON file projection and inner set -euo pipefail

Verification

reproduced the old failure locally: superseded_prs captured sync hooks: ✔️ (pre-push) from nix develop --command jq
real Forgejo API projection inside Nix shell: projected_json=[], json_projection_ok
mocked release PR selection inside one Nix shell: superseded=<123> existing=<456>, selection_ok
rtk cargo test -p ar-gateway --test ci_workflow_contract
rtk just fmt

## Summary - run jq PR selection and tea close/create/edit inside one Nix shell - avoid capturing `nix develop` shellHook stdout (`sync hooks`) as PR IDs - keep API JSON file projection and inner `set -euo pipefail` ## Verification - reproduced the old failure locally: `superseded_prs` captured `sync hooks: ✔️ (pre-push)` from `nix develop --command jq` - real Forgejo API projection inside Nix shell: `projected_json=[]`, `json_projection_ok` - mocked release PR selection inside one Nix shell: `superseded=<123> existing=<456>`, `selection_ok` - `rtk cargo test -p ar-gateway --test ci_workflow_contract` - `rtk just fmt`

jwilger added 1 commit

2026-05-17 20:44:27 -07:00

fix(release): keep PR selection inside Nix

CI / Format check (pull_request) Successful in 6s

Details

CI / Clippy (pull_request) Successful in 40s

Details

CI / Dependency policy (pull_request) Successful in 10s

Details

CI / Test (pull_request) Successful in 52s

Details

CI / Build (pull_request) Successful in 32s

Details

CI / Request auto_review semantic review (pull_request) Successful in 1s

Details

CI / Build PR artifacts (no token) (pull_request) Successful in 2s

Details

auto_review auto_review: no findings

b44480796d

auto-review approved these changes

2026-05-17 20:46:04 -07:00

auto-review left a comment

Walkthrough

.forgejo/workflows/release-prepare.yml:
- Consolidated multiple nix develop invocations into a single shell script block.
- Ensured that jq and tea commands are executed within the same Nix environment to prevent stdout interference.
crates/ar-gateway/tests/ci_workflow_contract.rs:
- Updated tests to reflect changes in how open PR JSON is handled and verified that Nix stdout does not interfere with JSON parsing.

The PR refactors the release preparation workflow to run all PR selection and management commands inside a single Nix shell, addressing issues with stdout interference. The changes appear safe to merge, but thorough testing is recommended to ensure the fix is effective. ## Walkthrough - **.forgejo/workflows/release-prepare.yml**: - Consolidated multiple `nix develop` invocations into a single shell script block. - Ensured that `jq` and `tea` commands are executed within the same Nix environment to prevent stdout interference. - **crates/ar-gateway/tests/ci_workflow_contract.rs**: - Updated tests to reflect changes in how open PR JSON is handled and verified that Nix stdout does not interfere with JSON parsing.

jwilger merged commit d5b2e7cbfa into main

2026-05-17 20:46:29 -07:00

jwilger deleted branch fix/release-prepare-pr-selection

2026-05-17 20:46:29 -07:00

jwilger referenced this pull request from a commit

2026-05-17 20:46:29 -07:00

fix(release): keep PR selection inside Nix (#240)