Bug: PR metadata check rejects valid imperative titles in non-conventional-commit projects #273

New issue

Closed

opened 2026-05-19 14:58:42 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-19 14:58:42 -07:00

Owner

Problem

Auto Review's PR metadata quality pre-merge check incorrectly failed a PR title in a project that does not use conventional commits.

Observed on Slipstream/eddy PR #4:

Comment: Slipstream/eddy#4 (comment)
Prior Auto Review output: Slipstream/eddy#4 (comment)

The bot reported:

PR metadata quality: failed
Rationale: The title does not use an imperative verb or a conventional commit prefix. It should start with a verb like 'Add', 'Implement', or follow a conventional commit format.
Offending text: Add auto_review CI trigger

But the title Add auto_review CI trigger already starts with the imperative verb Add, matching the stated non-conventional-commit fallback criteria.

Expected behavior

For repositories/projects that do not require conventional commits, PR metadata validation should accept an imperative-title style such as Add auto_review CI trigger.

If conventional commits are optional, the check should not fail simply because the title lacks a conventional commit prefix.

Actual behavior

The check failed even though the title satisfied the bot's own stated fallback rule.

A follow-up user comment also asked for approval because the PR metadata was not actually a problem, but Auto Review continued responding with summaries instead of addressing/clearing the incorrect metadata failure.

Impact

Valid PRs in non-conventional-commit projects can be blocked or marked as failing due to incorrect metadata analysis, reducing trust in Auto Review's pre-merge checks.

Notes

This may be either:

prompt/schema logic conflating conventional-commit requirements with imperative-title fallback, or
repository configuration not being passed/respected when deciding metadata policy.

## Problem Auto Review's PR metadata quality pre-merge check incorrectly failed a PR title in a project that does not use conventional commits. Observed on Slipstream/eddy PR #4: - Comment: https://git.johnwilger.com/Slipstream/eddy/pulls/4#issuecomment-8756 - Prior Auto Review output: https://git.johnwilger.com/Slipstream/eddy/pulls/4#issuecomment-8753 The bot reported: > PR metadata quality: failed > Rationale: The title does not use an imperative verb or a conventional commit prefix. It should start with a verb like 'Add', 'Implement', or follow a conventional commit format. > Offending text: Add auto_review CI trigger But the title `Add auto_review CI trigger` already starts with the imperative verb `Add`, matching the stated non-conventional-commit fallback criteria. ## Expected behavior For repositories/projects that do not require conventional commits, PR metadata validation should accept an imperative-title style such as `Add auto_review CI trigger`. If conventional commits are optional, the check should not fail simply because the title lacks a conventional commit prefix. ## Actual behavior The check failed even though the title satisfied the bot's own stated fallback rule. A follow-up user comment also asked for approval because the PR metadata was not actually a problem, but Auto Review continued responding with summaries instead of addressing/clearing the incorrect metadata failure. ## Impact Valid PRs in non-conventional-commit projects can be blocked or marked as failing due to incorrect metadata analysis, reducing trust in Auto Review's pre-merge checks. ## Notes This may be either: - prompt/schema logic conflating conventional-commit requirements with imperative-title fallback, or - repository configuration not being passed/respected when deciding metadata policy.

jwilger added this to the 1.0 milestone

2026-05-19 16:32:46 -07:00

jwilger added the

bug

label

2026-05-19 16:33:04 -07:00

jwilger referenced this issue from a pull request that will close it,

2026-05-19 21:14:12 -07:00

fix(review): handle imperative metadata and quoted feedback #279

jwilger closed this issue

2026-05-19 21:16:28 -07:00

jwilger referenced this issue from a commit