Handle review requests from Forgejo #49

New issue

Closed

opened 2026-05-03 08:29:58 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-03 08:29:58 -07:00

Owner

Problem

Branch protection can block merges while auto-review remains an outstanding requested reviewer. Today the gateway/orchestrator does not treat Forgejo review-request events as a review trigger, so requesting review from auto-review can leave a PR waiting even when CI and the auto_review status are green.

Observed on PR #48: Forgejo showed REQUEST_REVIEW by @auto-review; statuses were successful, but the PR was still not ready to merge because branch protection has block_on_official_review_requests enabled.

Desired behavior

When auto-review is requested as a reviewer on a PR, auto_review should respond instead of leaving the request pending.

Acceptance criteria

Gateway recognizes the relevant Forgejo webhook event/action for review requests to the configured bot identity.
A review request for auto-review enqueues a semantic review job for the current PR head, or otherwise performs an explicit supported response that clears the pending reviewer state.
Non-bot review requests are ignored.
Draft or closed PRs are not reviewed.
Tests cover the webhook payload shape and ensure only requests targeting the bot dispatch/respond.
Operator docs mention review-request triggering if supported.

Notes

Existing trigger paths are pull_request opened/synchronized/reopened, issue-comment chat mentions, and the new CI endpoint in PR #48. Review-request events are not currently handled.

## Problem Branch protection can block merges while `auto-review` remains an outstanding requested reviewer. Today the gateway/orchestrator does not treat Forgejo review-request events as a review trigger, so requesting review from `auto-review` can leave a PR waiting even when CI and the `auto_review` status are green. Observed on PR #48: Forgejo showed `REQUEST_REVIEW by @auto-review`; statuses were successful, but the PR was still not ready to merge because branch protection has `block_on_official_review_requests` enabled. ## Desired behavior When `auto-review` is requested as a reviewer on a PR, auto_review should respond instead of leaving the request pending. ## Acceptance criteria - Gateway recognizes the relevant Forgejo webhook event/action for review requests to the configured bot identity. - A review request for `auto-review` enqueues a semantic review job for the current PR head, or otherwise performs an explicit supported response that clears the pending reviewer state. - Non-bot review requests are ignored. - Draft or closed PRs are not reviewed. - Tests cover the webhook payload shape and ensure only requests targeting the bot dispatch/respond. - Operator docs mention review-request triggering if supported. ## Notes Existing trigger paths are `pull_request` opened/synchronized/reopened, issue-comment chat mentions, and the new CI endpoint in PR #48. Review-request events are not currently handled.

jwilger referenced this issue from a pull request that will close it,

2026-05-03 15:01:08 -07:00

fix(gateway): handle bot review requests #60

jwilger closed this issue

2026-05-03 15:25:37 -07:00

jwilger referenced this issue from a commit

2026-05-03 15:25:37 -07:00

fix(gateway): handle bot review requests (#60)