fix(review): approve warning-only auto reviews #55

New issue

Closed

opened 2026-05-03 11:18:42 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-03 11:18:42 -07:00

Owner

Problem

Branch protection can stay blocked after AR previously requested changes, even when a later review only reports warning-severity findings. Today AR maps warning-only output to a Forgejo COMMENT review, so it does not supersede stale REQUEST_CHANGES reviews or satisfy the required approval gate.

In practice, AR warnings are usually advisory reminders for a human reviewer to check something, not merge blockers. The commit status already treats warning-only reviews as success, but the review event does not.

Desired behavior

Error findings continue to post REQUEST_CHANGES.
Pre-merge check failures continue to post REQUEST_CHANGES.
Warning-only or note-only findings post an APPROVED review while preserving inline comments.
Clean zero-finding reviews continue to post APPROVED.

Acceptance criteria

A warning-only ReviewOutput maps to ReviewEvent::Approved with inline comments retained.
An error finding still maps to ReviewEvent::RequestChanges.
Pre-merge failure override still forces RequestChanges.
Add/adjust regression tests documenting that advisory warnings do not block merge approval.

## Problem Branch protection can stay blocked after AR previously requested changes, even when a later review only reports warning-severity findings. Today AR maps warning-only output to a Forgejo COMMENT review, so it does not supersede stale REQUEST_CHANGES reviews or satisfy the required approval gate. In practice, AR warnings are usually advisory reminders for a human reviewer to check something, not merge blockers. The commit status already treats warning-only reviews as success, but the review event does not. ## Desired behavior - Error findings continue to post REQUEST_CHANGES. - Pre-merge check failures continue to post REQUEST_CHANGES. - Warning-only or note-only findings post an APPROVED review while preserving inline comments. - Clean zero-finding reviews continue to post APPROVED. ## Acceptance criteria - A warning-only `ReviewOutput` maps to `ReviewEvent::Approved` with inline comments retained. - An error finding still maps to `ReviewEvent::RequestChanges`. - Pre-merge failure override still forces `RequestChanges`. - Add/adjust regression tests documenting that advisory warnings do not block merge approval.

jwilger referenced this issue from a pull request that will close it,

2026-05-03 13:31:21 -07:00

feat(review): retire bundled linter execution #54

jwilger closed this issue

2026-05-03 13:34:06 -07:00

jwilger referenced this issue from a commit

2026-05-03 13:34:07 -07:00

feat(review): retire bundled linter execution (#54)