Trim redundant review body; make Walkthrough incremental per-review #14

Open
opened 2026-05-01 14:19:15 -07:00 by auto-review · 0 comments
Collaborator

Reviews 709, 710, 711, 712 all open the same way:

"This PR addresses ..." / "This PR fixes ..." / "This PR fixes several issues, including ..."

That's a restatement of the PR description the author already wrote. It adds no signal, and on every push the bot generates a fresh paraphrase of the same thing, which makes successive reviews feel repetitive.

Proposed:

  1. Drop the "This PR addresses ..." preamble from the review body. The PR description owns that — the bot shouldn't re-summarise what the PR is for. If the description is empty or low-quality, see the partner issue (qualitative gate on title/description) for the right place to flag it.
  2. Make the Walkthrough incremental. On the first review of a PR, walk through the whole diff. On every subsequent review, walk through only what's changed since the previous review's head SHA — i.e., the compare diff between prev_review.commit_id and the current head. The orchestrator already knows this (the dispatcher logs "incremental review: fetching compare diff" when it builds it). The Walkthrough should narrow to that delta, with one line at top like "Δ since : …", and skip the section entirely when nothing material changed (e.g., empty merge-from-main commits, fmt-only fixups).

Touches: crates/ar-review/src/mapping.rs (render_body), the prompt builder in crates/ar-prompts/src/prompt.rs (the prompt should ask for an incremental walkthrough when given a previous review), and crates/ar-orchestrator/src/dispatcher.rs for surfacing the previous-review SHA + diff into the prompt context.

Related: #8 (line-comment dedup) — same principle, different scope.

Reviews 709, 710, 711, 712 all open the same way: > "This PR addresses ..." / "This PR fixes ..." / "This PR fixes several issues, including ..." That's a restatement of the PR description the author already wrote. It adds no signal, and on every push the bot generates a fresh paraphrase of the same thing, which makes successive reviews feel repetitive. **Proposed:** 1. **Drop the "This PR addresses ..." preamble** from the review body. The PR description owns that — the bot shouldn't re-summarise what the PR is for. If the description is empty or low-quality, see the partner issue (qualitative gate on title/description) for the right place to flag it. 2. **Make the Walkthrough incremental.** On the *first* review of a PR, walk through the whole diff. On every subsequent review, walk through *only what's changed since the previous review's head SHA* — i.e., the compare diff between `prev_review.commit_id` and the current head. The orchestrator already knows this (the dispatcher logs "incremental review: fetching compare diff" when it builds it). The Walkthrough should narrow to that delta, with one line at top like "Δ since <short-sha>: …", and skip the section entirely when nothing material changed (e.g., empty merge-from-main commits, fmt-only fixups). Touches: `crates/ar-review/src/mapping.rs` (`render_body`), the prompt builder in `crates/ar-prompts/src/prompt.rs` (the prompt should ask for an incremental walkthrough when given a previous review), and `crates/ar-orchestrator/src/dispatcher.rs` for surfacing the previous-review SHA + diff into the prompt context. Related: #8 (line-comment dedup) — same principle, different scope.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jwilger/auto_review#14
No description provided.