jwilger/auto_review
1
0
Fork 0
Code Issues 6 Pull requests 1 Releases Packages 1 Activity Actions

fix(nix): align cargo-fmt rustfmt with dev shell #39

Merged
jwilger merged 1 commit from fix/issue-12-rustfmt-alignment into main 2026-05-02 12:49:19 -07:00
Conversation 1 Commits 1 Files changed 2 +12
jwilger commented 2026-05-02 12:46:24 -07:00
Owner
Copy link

Summary

  • Set the Nix cargo-fmt check's RUSTFMT environment variable to the exact rustfmt binary from the dev-shell Rust toolchain.
  • Document the formatter alignment in the Unreleased changelog.

Verification

  • nix eval --raw .#checks.x86_64-linux.cargo-fmt.RUSTFMT
  • nix develop --command sh -c 'printf %s "/nix/store/z9v3lp64k3dliwlvx7icq44a6kykarqv-rust-minimal-1.97.0-nightly-2026-05-01/bin/rustfmt"'
  • nix build .#checks.x86_64-linux.cargo-fmt
  • git diff --check -- flake.nix CHANGELOG.md

Closes #12

## Summary - Set the Nix cargo-fmt check's RUSTFMT environment variable to the exact rustfmt binary from the dev-shell Rust toolchain. - Document the formatter alignment in the Unreleased changelog. ## Verification - nix eval --raw .#checks.x86_64-linux.cargo-fmt.RUSTFMT - nix develop --command sh -c 'printf %s "/nix/store/z9v3lp64k3dliwlvx7icq44a6kykarqv-rust-minimal-1.97.0-nightly-2026-05-01/bin/rustfmt"' - nix build .#checks.x86_64-linux.cargo-fmt - git diff --check -- flake.nix CHANGELOG.md Closes #12
fix(nix): align cargo-fmt rustfmt with dev shell
All checks were successful
auto_review auto_review: 1 warning
CI / Nix flake check (pull_request) Successful in 5s
Details
4166c43a5c
auto-review reviewed 2026-05-02 12:46:34 -07:00
auto-review left a comment
Copy link

This PR aligns the cargo-fmt check's RUSTFMT environment variable with the rustfmt binary from the dev-shell Rust toolchain, ensuring consistency between local and CI environments. The changes appear safe to merge, but ensure that the rustToolchain variable is correctly defined.

Walkthrough

  • CHANGELOG.md:
    • Added a section documenting the alignment of the cargo-fmt check with the dev-shell Rust toolchain's rustfmt binary.
  • flake.nix:
    • Updated the cargo-fmt check to set the RUSTFMT environment variable to the rustfmt binary from the dev-shell Rust toolchain, ensuring consistent formatting across environments.

Pre-merge checks

  • [~] CHANGELOG updated — diff is docs/config only — no CHANGELOG entry expected
  • [~] Tests touched — no source files in the diff
  • No new TODO/FIXME comments — no new TODO/FIXME markers
This PR aligns the `cargo-fmt` check's `RUSTFMT` environment variable with the rustfmt binary from the dev-shell Rust toolchain, ensuring consistency between local and CI environments. The changes appear safe to merge, but ensure that the `rustToolchain` variable is correctly defined. ## Walkthrough - **CHANGELOG.md**: - Added a section documenting the alignment of the `cargo-fmt` check with the dev-shell Rust toolchain's rustfmt binary. - **flake.nix**: - Updated the `cargo-fmt` check to set the `RUSTFMT` environment variable to the rustfmt binary from the dev-shell Rust toolchain, ensuring consistent formatting across environments. ## Pre-merge checks - [~] CHANGELOG updated — diff is docs/config only — no CHANGELOG entry expected - [~] Tests touched — no source files in the diff - [x] No new TODO/FIXME comments — no new TODO/FIXME markers
flake.nix
auto-review commented 2026-05-02 12:46:34 -07:00
Collaborator
Copy link

🟡 Warning: Verify that the rustToolchain variable is correctly defined and points to the intended Rust toolchain. This ensures that the correct rustfmt binary is used consistently.

🟡 **Warning:** Verify that the `rustToolchain` variable is correctly defined and points to the intended Rust toolchain. This ensures that the correct `rustfmt` binary is used consistently.
jwilger commented 2026-05-02 12:49:08 -07:00
Author
Owner
Copy link

Verified. rustToolchain is the single toolchain value loaded from ./rust-toolchain.toml via pkgs.rust-bin.fromRustupToolchainFile, and it is already used by both craneLib = (crane.mkLib pkgs).overrideToolchain rustToolchain and devShells.default.buildInputs. I also verified that nix eval --raw .#checks.x86_64-linux.cargo-fmt.RUSTFMT and nix develop --command sh -c 'command -v rustfmt' resolve to the same /nix/store/...-rust-minimal-1.97.0-nightly-2026-05-01/bin/rustfmt path, so no code change is needed for this thread.

Verified. `rustToolchain` is the single toolchain value loaded from `./rust-toolchain.toml` via `pkgs.rust-bin.fromRustupToolchainFile`, and it is already used by both `craneLib = (crane.mkLib pkgs).overrideToolchain rustToolchain` and `devShells.default.buildInputs`. I also verified that `nix eval --raw .#checks.x86_64-linux.cargo-fmt.RUSTFMT` and `nix develop --command sh -c 'command -v rustfmt'` resolve to the same `/nix/store/...-rust-minimal-1.97.0-nightly-2026-05-01/bin/rustfmt` path, so no code change is needed for this thread.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jwilger/auto_review!39
No description provided.