Review-quality gaps surfaced by dogfooding (PR #4) #5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closed in favour of separate per-concern issues — see linked tickets below. Keeping the original body intact for the dogfooding context.
Adding a design note from continued dogfooding:
The note tier is for the LLM, not the human. Severity=note observations seem to actively help the LLM produce a more thorough review pass — they force it to externalize what it noticed about the diff. But those same observations are noise on the PR. The 16 notes across reviews 709–711 are the failure mode: every one is a restatement of "this change does X."
Proposed fix, lighter than rewriting the prompt:
AR_SEVERITY_FLOOR=warninginstead ofnote. Notes still appear in the schema (so the LLM can emit them as scratchpad reasoning) but the post-step filter drops them before anything reaches Forgejo.AR_SEVERITY_FLOOR=note.This sidesteps having to teach the LLM "don't be noisy" via prompt — much harder — and recovers most of section 1's value mechanically. Combined with section 2 (pre-merge fail → RequestChanges) and section 3 (dedup-on-resolved), the bot's output should converge on "silent unless there's something actionable."