jwilger/auto_review
1
0
Fork 0
Code Issues 6 Pull requests 1 Releases Packages 1 Activity Actions

Pre-merge check failures should set review event to RequestChanges #7

New issue
Closed
opened 2026-05-01 13:58:36 -07:00 by auto-review · 0 comments
auto-review commented 2026-05-01 13:58:36 -07:00
Collaborator
Copy link

crates/ar-review/src/mapping.rs:17-25 only escalates the review event to RequestChanges when at least one finding has severity=Error. Pre-merge check failures (CHANGELOG missing, tests missing, no-new-todos triggered, repo-author custom natural-language checks failing) render in the review body but don't influence the event.

That's a real gap — a missing CHANGELOG or missing tests is a stronger "don't merge yet" signal than most note-level findings, but the review still posts as event=Comment.

Proposed: any failed pre-merge check (built-in deterministic OR repo-author-supplied) bumps event to RequestChanges, regardless of finding severities. A single boolean in the mapping function.

Touches: crates/ar-review/src/mapping.rs and probably the call site in crates/ar-orchestrator/src/dispatcher.rs (whichever assembles the final ReviewOutput → CreateReviewRequest).

`crates/ar-review/src/mapping.rs:17-25` only escalates the review event to `RequestChanges` when at least one finding has severity=Error. Pre-merge check failures (CHANGELOG missing, tests missing, no-new-todos triggered, repo-author custom natural-language checks failing) render in the review body but don't influence the event. That's a real gap — a missing CHANGELOG or missing tests is a stronger "don't merge yet" signal than most note-level findings, but the review still posts as event=Comment. **Proposed:** any failed pre-merge check (built-in deterministic OR repo-author-supplied) bumps event to RequestChanges, regardless of finding severities. A single boolean in the mapping function. Touches: `crates/ar-review/src/mapping.rs` and probably the call site in `crates/ar-orchestrator/src/dispatcher.rs` (whichever assembles the final ReviewOutput → CreateReviewRequest).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
issue-10-mandatory-sandbox
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jwilger/auto_review#7
No description provided.