Remove dead code: PollMode::Continuous and unused projection config #271

New issue

Closed

opened 2025-12-31 16:49:17 -08:00 by jwilger · 1 comment

jwilger commented

2025-12-31 16:49:17 -08:00

(Migrated from github.com)

Summary

Remove dead code from the projection module that was identified during the ADR-030 analysis.

Parent Issue

#266 Implement ADR-030: Layered Crate Public API Design

Dead Code to Remove

PollMode::Continuous variant - Never constructed, marked as dead code by compiler
ProjectionRunner::with_poll_mode() method - Never used
ProjectionRunner::with_poll_config() method - Never used
ProjectionRunner::with_event_retry_config() method - Never used

Context

During the ADR-030 analysis, cargo check reported these as dead code:

error: variant `Continuous` is never constructed
error: methods `with_poll_mode`, `with_poll_config`, and `with_event_retry_config` are never used

Since these are being removed from the public API anyway, we should remove the dead code entirely rather than keeping unused internal code.

Acceptance Criteria

PollMode::Continuous removed
Unused with_* methods removed from ProjectionRunner
No dead code warnings
All tests pass

## Summary Remove dead code from the projection module that was identified during the ADR-030 analysis. ## Parent Issue - #266 Implement ADR-030: Layered Crate Public API Design ## Dead Code to Remove 1. **`PollMode::Continuous` variant** - Never constructed, marked as dead code by compiler 2. **`ProjectionRunner::with_poll_mode()` method** - Never used 3. **`ProjectionRunner::with_poll_config()` method** - Never used 4. **`ProjectionRunner::with_event_retry_config()` method** - Never used ## Context During the ADR-030 analysis, `cargo check` reported these as dead code: ``` error: variant `Continuous` is never constructed error: methods `with_poll_mode`, `with_poll_config`, and `with_event_retry_config` are never used ``` Since these are being removed from the public API anyway, we should remove the dead code entirely rather than keeping unused internal code. ## Acceptance Criteria - [ ] `PollMode::Continuous` removed - [ ] Unused `with_*` methods removed from `ProjectionRunner` - [ ] No dead code warnings - [ ] All tests pass

jwilger commented

2025-12-31 17:32:27 -08:00

(Migrated from github.com)

Closing: Parent issue closed