BASE-1: Generate Phoenix 1.8 application baseline #61
No reviewers
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Slipstream/anything_app!61
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-7-generate-phoenix-baseline"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Verification
mix test test/anything_web/controllers/page_controller_test.exsmix assets.buildmix format --check-formattedMIX_ENV=test mix compile --warnings-as-errors --forceMIX_ENV=prod mix compile --warnings-as-errors --forcemix test --warnings-as-errorsnpm run check:event-modelNotes
mix dialyzer --halt-exit-status,mix credo --strict, andmix sobeloware deferred because those Mix tasks are not configured yet; #11 tracks baseline verification gates.mix teston the pre-baseline tree failed because no Mix project existed yet.Closes #7
@ -0,0 +1,18 @@# AnythingTo start your Phoenix server:Update the README.md so that it actually describes what we are attempting to build.
Addressed. Reflection: I left the generated Phoenix README in place instead of replacing it with the project/product description from the roadmap; this was a one-off documentation drift, not a guardrail gap. I updated
README.mdto describe the defect-driven self-building workflow, current baseline, setup, configuration, and verification.@ -0,0 +67,4 @@# Import environment specific config. This must remain at the bottom# of this file so it overrides the configuration defined above.import_config "#{config_env()}.exs"Instead of having per-environment configs, let's unify to having only config/config.exs and config/runtime.exs and use environment variables to make this a true, 12factor app. I suggest using the config_helper hex package to...well...help config.
Addressed. Reflection: I accepted the generated per-environment Phoenix config instead of applying the project’s 12-factor preference during baseline generation; this was a one-off configuration drift, not a guardrail gap. I centralized config into
config/config.exsandconfig/runtime.exs, removed the per-environment config files/import, addedconfig_helper, preserved dev/test Ecto task visibility and Postgres env overrides inconfig.exs, and kept explicit prodDATABASE_URL/SECRET_KEY_BASEruntime raises.