BASE-1: Address Phoenix baseline review feedback #62

Merged
jwilger merged 1 commit from issue-7-baseline-review-feedback into main 2026-05-07 09:43:34 -07:00
Owner

Summary

  • Replaces the generated Phoenix README with project-specific baseline, setup, configuration, and verification guidance.
  • Centralizes Phoenix configuration into config/config.exs and config/runtime.exs, removes per-environment config files, and adds config_helper for runtime environment parsing.
  • Adds focused configuration tests that protect centralized config topology, Ecto task visibility, and explicit production required-env failures.

Verification

  • mix test test/configuration_test.exs
  • mix format --check-formatted
  • MIX_ENV=test mix compile --warnings-as-errors --force
  • DATABASE_URL=... SECRET_KEY_BASE=... MIX_ENV=prod mix compile --warnings-as-errors --force
  • mix test --warnings-as-errors
  • mix assets.build
  • npm run check:event-model

Context

Follow-up to review feedback on merged PR #61.

## Summary - Replaces the generated Phoenix README with project-specific baseline, setup, configuration, and verification guidance. - Centralizes Phoenix configuration into config/config.exs and config/runtime.exs, removes per-environment config files, and adds config_helper for runtime environment parsing. - Adds focused configuration tests that protect centralized config topology, Ecto task visibility, and explicit production required-env failures. ## Verification - mix test test/configuration_test.exs - mix format --check-formatted - MIX_ENV=test mix compile --warnings-as-errors --force - DATABASE_URL=... SECRET_KEY_BASE=... MIX_ENV=prod mix compile --warnings-as-errors --force - mix test --warnings-as-errors - mix assets.build - npm run check:event-model ## Context Follow-up to review feedback on merged PR #61.
Sign in to join this conversation.
No description provided.