Fix chat poller bot identity default/logging for hyphenated bot name #128

New issue

Closed

opened 2026-05-06 16:05:27 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-06 16:05:27 -07:00

Owner

Observed

Gateway startup logs report:

chat poller running interval_secs=60 bot_login=auto_review bot_name=auto_review

The actual bot name/login for this deployment is auto-review.

Related/superseded issue: #80 (Use @auto-review mention for bot comments).

Why this matters

If the chat poller is using the underscore default instead of the configured Forgejo bot identity, it may misclassify self-authored comments or miss/handle mentions incorrectly. At minimum, the startup log is misleading for operators validating bot identity.

Expected

Startup logs should report the effective configured bot identity exactly as Forgejo uses it.
Chat self-comment filtering and mention handling should use the same effective identity.
Chat/comment command recognition should accept @auto-review, matching the public bot identity.
Defaults/docs should not imply auto_review when the single-binary rollout uses auto-review as the public bot identity.
Consider whether @auto_review should remain as a temporary compatibility alias during the transition.

Acceptance criteria

Add a regression test for effective bot identity in chat poller startup/config wiring.
Verify self-comment detection and mention handling use the configured hyphenated identity.
Verify chat/comment commands addressed to @auto-review are recognized.
Decide and test/document whether @auto_review remains as a temporary compatibility alias.
Update docs/env examples if they still show the wrong default identity or mention syntax.

## Observed Gateway startup logs report: ```text chat poller running interval_secs=60 bot_login=auto_review bot_name=auto_review ``` The actual bot name/login for this deployment is `auto-review`. Related/superseded issue: #80 (`Use @auto-review mention for bot comments`). ## Why this matters If the chat poller is using the underscore default instead of the configured Forgejo bot identity, it may misclassify self-authored comments or miss/handle mentions incorrectly. At minimum, the startup log is misleading for operators validating bot identity. ## Expected - Startup logs should report the effective configured bot identity exactly as Forgejo uses it. - Chat self-comment filtering and mention handling should use the same effective identity. - Chat/comment command recognition should accept `@auto-review`, matching the public bot identity. - Defaults/docs should not imply `auto_review` when the single-binary rollout uses `auto-review` as the public bot identity. - Consider whether `@auto_review` should remain as a temporary compatibility alias during the transition. ## Acceptance criteria - Add a regression test for effective bot identity in chat poller startup/config wiring. - Verify self-comment detection and mention handling use the configured hyphenated identity. - Verify chat/comment commands addressed to `@auto-review` are recognized. - Decide and test/document whether `@auto_review` remains as a temporary compatibility alias. - Update docs/env examples if they still show the wrong default identity or mention syntax.

jwilger added the

bug

label

2026-05-08 11:44:04 -07:00

jwilger referenced this issue

2026-05-09 09:12:26 -07:00

Use @auto-review mention for bot comments #80

jwilger referenced this issue from a pull request that will close it,

2026-05-09 10:48:23 -07:00

fix(chat): use hyphenated bot identity #177

jwilger closed this issue

2026-05-09 12:05:00 -07:00