Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(chat): use hyphenated bot identity #177

Merged
jwilger merged 1 commit from fix/issue-128-chat-bot-identity into main 2026-05-09 12:04:59 -07:00
Conversation 1 Commits 1 Files changed 11 +289 -59
jwilger commented 2026-05-09 10:48:23 -07:00
Owner
Copy link

Summary

  • Change the default chat bot identity from auto_review to auto-review across startup config, webhook state, and poller wiring.
  • Recognize @auto-review as the public mention while retaining @auto_review as a temporary compatibility alias.
  • Update operator docs, env examples, and threat-model references to use the hyphenated identity.

Verification

  • nix develop -c cargo fmt --all -- --check
  • nix develop -c cargo test -p ar-gateway hyphenated_bot_identity -- --nocapture
  • nix develop -c cargo test -p ar-chat hyphenated_bot_identity -- --nocapture
  • nix develop -c cargo nextest run -p ar-chat -p ar-gateway
  • nix develop -c cargo clippy -p ar-chat -p ar-gateway --all-targets -- -D warnings

Closes #128

PR artifacts for f490b63664:

Docker image: git.johnwilger.com/jwilger/auto_review/ar-gateway-pr:pr-177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a
binary download: https://git.johnwilger.com/api/packages/jwilger/generic/auto-review-pr/177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a/auto-review-pr-177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a-linux-x86_64.tar.gz
SHA256SUMS: https://git.johnwilger.com/api/packages/jwilger/generic/auto-review-pr/177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a/SHA256SUMS

## Summary - Change the default chat bot identity from `auto_review` to `auto-review` across startup config, webhook state, and poller wiring. - Recognize `@auto-review` as the public mention while retaining `@auto_review` as a temporary compatibility alias. - Update operator docs, env examples, and threat-model references to use the hyphenated identity. ## Verification - `nix develop -c cargo fmt --all -- --check` - `nix develop -c cargo test -p ar-gateway hyphenated_bot_identity -- --nocapture` - `nix develop -c cargo test -p ar-chat hyphenated_bot_identity -- --nocapture` - `nix develop -c cargo nextest run -p ar-chat -p ar-gateway` - `nix develop -c cargo clippy -p ar-chat -p ar-gateway --all-targets -- -D warnings` Closes #128 <!-- auto_review:artifact-links:start --> PR artifacts for f490b63664dd866b99e32bc5d32bb2c20a1f1e3a: Docker image: git.johnwilger.com/jwilger/auto_review/ar-gateway-pr:pr-177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a binary download: https://git.johnwilger.com/api/packages/jwilger/generic/auto-review-pr/177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a/auto-review-pr-177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a-linux-x86_64.tar.gz SHA256SUMS: https://git.johnwilger.com/api/packages/jwilger/generic/auto-review-pr/177-f490b63664dd866b99e32bc5d32bb2c20a1f1e3a/SHA256SUMS <!-- auto_review:artifact-links:end -->
fix(chat): use hyphenated bot identity
All checks were successful
CI / Verify PR with nix flake check (pull_request) Successful in 3m54s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
CI / Build PR artifacts (no token) (pull_request) Successful in 1m35s
Details
CI / Publish PR artifact packages (pull_request) Successful in 1m9s
Details
Clean PR packages / Delete packages for merged PRs (pull_request) Successful in 14s
Details
f490b63664
auto-review approved these changes 2026-05-09 10:52:36 -07:00
auto-review left a comment
Copy link

The PR updates the bot identity from auto_review to auto-review, ensuring compatibility with both forms temporarily. The changes are well-structured and include necessary updates to documentation and tests. The PR appears safe to merge.

Walkthrough

  • crates/ar-chat/src/command.rs:
    • Updated comments and documentation to reflect the new bot identity @auto-review.
    • Added a new test to verify the handling of both @auto-review and @auto_review mentions.
  • crates/ar-gateway/src/lib.rs:
    • Changed default bot identity to auto-review.
  • crates/ar-gateway/src/poller.rs:
    • Updated logic to handle mentions of both @auto-review and @auto_review.
  • crates/ar-gateway/src/startup.rs:
    • Refactored bot identity resolution into a separate function resolve_bot_identity.
  • Documentation and Deployment Files:
    • Updated all references to the bot identity to use auto-review.
The PR updates the bot identity from `auto_review` to `auto-review`, ensuring compatibility with both forms temporarily. The changes are well-structured and include necessary updates to documentation and tests. The PR appears safe to merge. ## Walkthrough - **crates/ar-chat/src/command.rs**: - Updated comments and documentation to reflect the new bot identity `@auto-review`. - Added a new test to verify the handling of both `@auto-review` and `@auto_review` mentions. - **crates/ar-gateway/src/lib.rs**: - Changed default bot identity to `auto-review`. - **crates/ar-gateway/src/poller.rs**: - Updated logic to handle mentions of both `@auto-review` and `@auto_review`. - **crates/ar-gateway/src/startup.rs**: - Refactored bot identity resolution into a separate function `resolve_bot_identity`. - **Documentation and Deployment Files**: - Updated all references to the bot identity to use `auto-review`.
jwilger deleted branch fix/issue-128-chat-bot-identity 2026-05-09 12:05:00 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!177
No description provided.