Harden staged OCI bundle cleanup on staging failures #147

Closed
opened 2026-05-07 15:06:54 -07:00 by jwilger · 0 comments
Owner

PR #126 review noted that staged OCI bundle cleanup is only guaranteed after runtime execution.

In crates/ar-gateway/src/startup.rs, stage_embedded_oci_gateway_bundle_at_path creates the staging directory before linking rootfs, reading/parsing config, and writing generated config. Failures after directory creation can leave residual staged bundle directories, and write failures may leave partial staged config.

Add focused tests covering staging failures after directory creation and ensure cleanup is best-effort but reliable, with sanitized diagnostics and no secret/path leakage.

Source feedback: PR #126 comment 2951.

PR #126 review noted that staged OCI bundle cleanup is only guaranteed after runtime execution. In `crates/ar-gateway/src/startup.rs`, `stage_embedded_oci_gateway_bundle_at_path` creates the staging directory before linking rootfs, reading/parsing config, and writing generated config. Failures after directory creation can leave residual staged bundle directories, and write failures may leave partial staged config. Add focused tests covering staging failures after directory creation and ensure cleanup is best-effort but reliable, with sanitized diagnostics and no secret/path leakage. Source feedback: PR #126 comment 2951.
jwilger added this to the 1.0 milestone 2026-05-08 11:43:27 -07:00
jwilger added this to the (deleted) project 2026-05-10 07:35:54 -07:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review#147
No description provided.