Harden staged OCI bundle cleanup on staging failures #147
Labels
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Slipstream/auto_review#147
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
PR #126 review noted that staged OCI bundle cleanup is only guaranteed after runtime execution.
In
crates/ar-gateway/src/startup.rs,stage_embedded_oci_gateway_bundle_at_pathcreates the staging directory before linking rootfs, reading/parsing config, and writing generated config. Failures after directory creation can leave residual staged bundle directories, and write failures may leave partial staged config.Add focused tests covering staging failures after directory creation and ensure cleanup is best-effort but reliable, with sanitized diagnostics and no secret/path leakage.
Source feedback: PR #126 comment 2951.