chore: release v0.3.0 #126
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Slipstream/auto_review!126
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "release/v0.3.0"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Prepare release v0.3.0.
Release candidate images:
bd09503dac634d137810This pull request prepares the release of version 0.3.0 by updating the version numbers in Cargo files and adding a new section to the CHANGELOG.md. The changes appear straightforward and safe to merge.
Walkthrough
634d137810bc32343a65New commits pushed, approval review dismissed automatically according to repository settings
bc32343a65201a5a588eThis release prepares version 0.3.0 with updates to the CLI and gateway components, including the addition of an embedded OCI runtime. The changes appear safe to merge, with some recommendations for additional tests and error handling improvements.
Walkthrough
Δ since
634d137:🟡 Warning: Ensure that the error messages do not leak sensitive information, especially when dealing with paths that might contain secrets.
🟡 Warning: Ensure that the cleanup process for staged OCI bundles is robust and handles potential errors gracefully to avoid leaving residual files.
🟡 Warning: Ensure that the
link_packaged_rootfsfunction handles symbolic links correctly and does not introduce security vulnerabilities by following unsafe paths.🟡 Warning: Ensure that the
execute_packaged_oci_runtime_with_executorfunction handles all potential errors from the executor and provides meaningful error messages.🟡 Warning: Ensure that the
run_packaged_oci_runtime_commandfunction handles all potential errors from the command execution and provides meaningful error messages.🟡 Warning: Ensure that the
prepare_embedded_oci_gatewayfunction handles all potential errors from environment variable retrieval and provides meaningful error messages.Valid and tracked as defect/bug #147: the staged bundle can be left behind when staging fails after directory creation. Follow-up should add focused failure-path tests and preserve sanitized diagnostics.
This path is already constrained before
link_packaged_rootfsruns: packaged OCI inputs must be absolute, traversal-free/nix/storepaths, and the staged rootfs symlink intentionally points at the trusted packaged rootfs. I do not see an actionable unsafe user-controlled symlink path here.Valid and tracked as defect/bug #148:
execute_packaged_oci_runtime_with_executorpreserves redaction but loses useful sanitized executor context, making operator diagnosis harder.run_packaged_oci_runtime_commandalready handles both spawn failures and non-success exit statuses with sanitized diagnostics (ErrorKind/ status) while clearing ambient env. I do not see a remaining defect in this helper itself.Valid and tracked as defect/bug #149:
prepare_embedded_oci_gatewaycollapses env retrieval errors such as non-Unicode values into missing/omitted values. Follow-up should report sanitized env-var-name diagnostics.201a5a588e6a3819d9bdNew commits pushed, approval review dismissed automatically according to repository settings
This PR prepares for the release of version 0.3.0 by updating the changelog and modifying the command path for the auto-review binary in the Docker image configuration. The changes appear safe to merge, but ensure the path updates align with deployment expectations.
Walkthrough
Δ since
201a5a5:CHANGELOG.md:
crates/ar-cli/src/cli.rs:
flake.nix:
6a3819d9bdede4f2d03cNew commits pushed, approval review dismissed automatically according to repository settings
This PR prepares for the release of version 0.3.0, introducing runtime isolation reporting and enhancing the status summary with isolation details. The changes appear safe to merge, with comprehensive tests added for the new functionality.
Walkthrough
Δ since
6a3819d:RuntimeIsolationSummaryto the status summary, with methods to determine isolation type.RuntimeIsolationPostureInfoto encapsulate isolation details and updated startup logic to classify and log runtime isolation posture.ede4f2d03c3421ef44ffNew commits pushed, approval review dismissed automatically according to repository settings
This release preparation for v0.3.0 includes documentation updates and clarifications on deployment strategies, particularly around the single-binary rollout and systemd deployment. The changes appear safe to merge, with no code-level issues identified.
Walkthrough
Δ since
ede4f2d:baremode and its implications.3421ef44ff1c2a8fc30cNew commits pushed, approval review dismissed automatically according to repository settings
This PR prepares the release of version 0.3.0, adding a NixOS deployment module and updating documentation. The changes appear safe to merge, but ensure thorough testing of the new deployment module.
Walkthrough
Δ since
3421ef4:CHANGELOG.md:
QUICKSTART.md:
flake.nix:
1c2a8fc30ce06ede8c31New commits pushed, approval review dismissed automatically according to repository settings
This PR prepares for the release of version 0.3.0 by updating workflows, documentation, and tests to support the publication of Linux binary artifacts. The changes appear well-structured and focus on enhancing the release process, but attention should be given to the secure handling of credentials and the thoroughness of new tests.
Walkthrough
Δ since
1c2a8fc:🟡 Warning: Lines 60–104: Ensure that the environment variables
RELEASE_SIGNING_KEY,RELEASE_BOT_EMAIL, andRELEASE_AARCH64_NIX_BUILDERare securely managed and documented, as they are critical for the release process.Already covered:
docs/OPERATIONS.mddocumentsRELEASE_SIGNING_KEY,RELEASE_BOT_EMAIL, andRELEASE_AARCH64_NIX_BUILDER, including the dedicated release bot, signing-key handling, and aarch64 builder requirement. The threat model also covers the release signing key and remote-builder trust boundary.🟡 Warning: Lines 8–9: Ensure that the threat model accurately reflects the new release process, including the handling of binary artifacts and the use of the release signing key for signing SHA256SUMS.
Valid and tracked as defect/bug #150: the detailed release threats are present, but the top-level threat model scope still describes only the self-hosted review bot. Follow-up should include release preparation/publishing automation and binary artifact integrity in scope.