Distinguish OCI launcher env retrieval failures from missing env vars #149

New issue

Closed

opened 2026-05-07 15:06:54 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-07 15:06:54 -07:00

Owner

PR #126 review noted that prepare_embedded_oci_gateway should handle environment variable retrieval errors explicitly.

The current implementation uses env::var(...).ok() for packaged OCI paths and inner gateway env lookup, collapsing NotPresent and NotUnicode. Required non-Unicode values are reported as missing, and optional allowlisted values may be silently omitted.

Add focused tests for non-Unicode env values where feasible, return sanitized diagnostics that name the env var without echoing values, and consider updating the env-parsing guardrail so it covers crates/ar-gateway/src/startup.rs rather than only main.rs.

Source feedback: PR #126 comment 2955.

PR #126 review noted that `prepare_embedded_oci_gateway` should handle environment variable retrieval errors explicitly. The current implementation uses `env::var(...).ok()` for packaged OCI paths and inner gateway env lookup, collapsing `NotPresent` and `NotUnicode`. Required non-Unicode values are reported as missing, and optional allowlisted values may be silently omitted. Add focused tests for non-Unicode env values where feasible, return sanitized diagnostics that name the env var without echoing values, and consider updating the env-parsing guardrail so it covers `crates/ar-gateway/src/startup.rs` rather than only `main.rs`. Source feedback: PR #126 comment 2955.

jwilger added the

bug

label

2026-05-07 15:07:07 -07:00

jwilger referenced this issue

2026-05-07 15:07:42 -07:00

chore: release v0.3.0 #126

jwilger removed the

bug

label

2026-05-08 11:42:28 -07:00

jwilger added this to the 1.0 milestone