refactor(nix): keep Nix for tooling, packaging, and NixOS service support #217

New issue

Closed

opened 2026-05-16 13:53:04 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-16 13:53:04 -07:00

Owner

Goal

Simplify flake.nix so Nix is no longer the CI orchestration layer, while preserving the parts that are valuable: dev-shell provisioning, production package assembly, embedded OCI rootfs/runtime packaging, and NixOS service installation.

Implements the retained-Nix boundary from ADR-0018.

Scope

Keep devShells.default.
Keep the default auto-review package.
Keep embedded OCI rootfs/runtime packaging used by the production Linux artifact.
Keep the NixOS module for installing/running the service on NixOS.
Remove flake checks whose purpose was to make nix flake check run the full CI gate.
Do not remove embedded OCI packaging.
Do not remove the NixOS module.
Update Nix-specific docs/comments affected by the flake simplification.

Acceptance Criteria

nix develop still provides the development tool environment.
nix build . still produces the production auto-review package.
The package still wires the embedded OCI bundle/runtime path needed by auto-review gateway.
The NixOS module still evaluates and points at the package.
Routine CI checks are no longer primarily encoded as flake checks.

Verification

nix develop
nix build .
just ci
Focused NixOS module evaluation/package check

Dependencies

Blocked by #216.

## Goal Simplify `flake.nix` so Nix is no longer the CI orchestration layer, while preserving the parts that are valuable: dev-shell provisioning, production package assembly, embedded OCI rootfs/runtime packaging, and NixOS service installation. Implements the retained-Nix boundary from ADR-0018. ## Scope - Keep `devShells.default`. - Keep the default `auto-review` package. - Keep embedded OCI rootfs/runtime packaging used by the production Linux artifact. - Keep the NixOS module for installing/running the service on NixOS. - Remove flake `checks` whose purpose was to make `nix flake check` run the full CI gate. - Do not remove embedded OCI packaging. - Do not remove the NixOS module. - Update Nix-specific docs/comments affected by the flake simplification. ## Acceptance Criteria - `nix develop` still provides the development tool environment. - `nix build .` still produces the production `auto-review` package. - The package still wires the embedded OCI bundle/runtime path needed by `auto-review gateway`. - The NixOS module still evaluates and points at the package. - Routine CI checks are no longer primarily encoded as flake checks. ## Verification - `nix develop` - `nix build .` - `just ci` - Focused NixOS module evaluation/package check ## Dependencies Blocked by #216.

jwilger added the

enhancement

label

2026-05-16 13:53:15 -07:00

jwilger added this to the 1.0 milestone

2026-05-16 13:54:04 -07:00

jwilger referenced this issue

2026-05-16 13:54:04 -07:00

chore(ci): run PR checks as parallel just-based Forgejo jobs #218

jwilger referenced this issue

2026-05-16 13:54:04 -07:00

refactor(release): remove official Docker image build outputs #219