chore(ci): run PR checks as parallel just-based Forgejo jobs #218

Closed
opened 2026-05-16 13:53:04 -07:00 by jwilger · 0 comments
Owner

Goal

Replace the single nix flake check PR gate with clearer, parallel Forgejo Actions jobs that use just recipes. CI may still use Nix to provision the environment, but Nix should not be the check orchestration interface.

Implements the PR CI portion of ADR-0018.

Scope

  • Update .forgejo/workflows/ci.yml.
  • Add a common build job that proves the production binary/package builds.
  • Add separate check jobs where practical:
    • fmt
    • clippy
    • test
    • deny
  • Have jobs run the corresponding just recipes.
  • CI may use Nix setup so the tool environment matches local nix develop.
  • Keep semantic review dependent on all required deterministic checks.
  • Keep logs separate and readable.
  • Update CI documentation/examples changed by this workflow shape.

Acceptance Criteria

  • PR CI no longer has a single “Verify PR with nix flake check” job.
  • Formatting, clippy, tests, and deny failures appear as separate jobs.
  • Semantic review only runs after required deterministic checks pass.
  • CI still uses the pinned toolchain/tool environment in a way consistent with the Nix dev shell.

Verification

  • Open PR and verify Forgejo Actions runs the new jobs.
  • Local just ci passes.
  • CI workflow does not publish Docker images.

Dependencies

Blocked by #217.

## Goal Replace the single `nix flake check` PR gate with clearer, parallel Forgejo Actions jobs that use `just` recipes. CI may still use Nix to provision the environment, but Nix should not be the check orchestration interface. Implements the PR CI portion of ADR-0018. ## Scope - Update `.forgejo/workflows/ci.yml`. - Add a common build job that proves the production binary/package builds. - Add separate check jobs where practical: - `fmt` - `clippy` - `test` - `deny` - Have jobs run the corresponding `just` recipes. - CI may use Nix setup so the tool environment matches local `nix develop`. - Keep semantic review dependent on all required deterministic checks. - Keep logs separate and readable. - Update CI documentation/examples changed by this workflow shape. ## Acceptance Criteria - PR CI no longer has a single “Verify PR with nix flake check” job. - Formatting, clippy, tests, and deny failures appear as separate jobs. - Semantic review only runs after required deterministic checks pass. - CI still uses the pinned toolchain/tool environment in a way consistent with the Nix dev shell. ## Verification - Open PR and verify Forgejo Actions runs the new jobs. - Local `just ci` passes. - CI workflow does not publish Docker images. ## Dependencies Blocked by #217.
jwilger added this to the 1.0 milestone 2026-05-16 13:54:04 -07:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
Slipstream/auto_review#218
No description provided.