Trigger semantic reviews from CI after required checks pass #42

New issue

Closed

opened 2026-05-02 19:41:05 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-02 19:41:05 -07:00

Owner

Problem

Today the gateway starts a semantic review directly from PR webhooks. That spends LLM tokens before deterministic CI has passed, so auto_review may review code that already has objective failures. It also forces the gateway to understand CI/check status ordering itself.

Direction

Make the normal review trigger come from CI after the project-selected prerequisite jobs pass. The gateway remains the persistent service for chat commands, review history, learnings, posting reviews, and deduplication; CI only decides when the code is ready for semantic review.

Acceptance

Add an authenticated gateway endpoint for CI-triggered review dispatch.
The request includes owner, repo, PR number, head SHA, and trigger metadata.
The gateway verifies the PR still exists and the supplied head SHA matches Forgejo before dispatching.
Existing review-history dedup still prevents duplicate reviews for the same SHA unless force is requested.
Document a Forgejo workflow where auto_review runs in a job with normal needs: dependencies after deterministic checks pass.

Follow-ups / dependencies

Blocks: the workflow action wrapper, disabling webhook auto-review dispatch, and removing bundled linter execution.

## Problem Today the gateway starts a semantic review directly from PR webhooks. That spends LLM tokens before deterministic CI has passed, so auto_review may review code that already has objective failures. It also forces the gateway to understand CI/check status ordering itself. ## Direction Make the normal review trigger come from CI after the project-selected prerequisite jobs pass. The gateway remains the persistent service for chat commands, review history, learnings, posting reviews, and deduplication; CI only decides when the code is ready for semantic review. ## Acceptance - Add an authenticated gateway endpoint for CI-triggered review dispatch. - The request includes owner, repo, PR number, head SHA, and trigger metadata. - The gateway verifies the PR still exists and the supplied head SHA matches Forgejo before dispatching. - Existing review-history dedup still prevents duplicate reviews for the same SHA unless force is requested. - Document a Forgejo workflow where auto_review runs in a job with normal `needs:` dependencies after deterministic checks pass. ## Follow-ups / dependencies Blocks: the workflow action wrapper, disabling webhook auto-review dispatch, and removing bundled linter execution.

jwilger referenced this issue

2026-05-02 19:41:17 -07:00

Add Forgejo workflow action for CI-triggered reviews #43

jwilger referenced this issue

2026-05-02 19:41:24 -07:00

Stop PR webhooks from automatically dispatching semantic reviews #44

jwilger referenced this issue

2026-05-02 19:41:32 -07:00

Remove bundled linter execution from the review pipeline #45

jwilger referenced this issue from a pull request that will close it,

2026-05-02 23:03:54 -07:00

feat(gateway): add CI-triggered review dispatch #48