Remove bundled linter execution from the review pipeline #45

New issue

Closed

opened 2026-05-02 19:41:32 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-02 19:41:32 -07:00

Owner

Problem

auto_review currently bundles and runs many deterministic linters, then tries to summarize or normalize their findings. That duplicates CI, creates vague review output like ok, N findings, requires a large sandbox image/toolchain, and blurs auto_review's responsibility with objective pass/fail checks.

Direction

Projects should run deterministic linters/tests/builds as CI jobs and make them required as needed. auto_review should focus on semantic and fuzzy review after those checks pass.

Acceptance

Remove linter execution from the normal review pipeline and orchestrator lint phase.
Stop passing linter findings into the semantic review prompt.
Remove or retire mode: linter_only and associated docs/tests.
Remove linter summary rendering from posted reviews.
Delete bundled linter toolchain/image pieces that are no longer used by any supported runtime path.
Update docs, CHANGELOG, and architecture notes to describe the CI-vs-auto_review responsibility split.
Tests prove a review can run from Forgejo PR metadata/diff without any bundled linter setup.

Dependencies

Blocked by: #42, #43, and #44, so CI can own deterministic gates before auto_review stops running bundled linters.

Supersedes most of #10's original motivation for a mandatory linter sandbox image.

## Problem auto_review currently bundles and runs many deterministic linters, then tries to summarize or normalize their findings. That duplicates CI, creates vague review output like `ok, N findings`, requires a large sandbox image/toolchain, and blurs auto_review's responsibility with objective pass/fail checks. ## Direction Projects should run deterministic linters/tests/builds as CI jobs and make them required as needed. auto_review should focus on semantic and fuzzy review after those checks pass. ## Acceptance - Remove linter execution from the normal review pipeline and orchestrator lint phase. - Stop passing linter findings into the semantic review prompt. - Remove or retire `mode: linter_only` and associated docs/tests. - Remove linter summary rendering from posted reviews. - Delete bundled linter toolchain/image pieces that are no longer used by any supported runtime path. - Update docs, CHANGELOG, and architecture notes to describe the CI-vs-auto_review responsibility split. - Tests prove a review can run from Forgejo PR metadata/diff without any bundled linter setup. ## Dependencies Blocked by: #42, #43, and #44, so CI can own deterministic gates before auto_review stops running bundled linters. Supersedes most of #10's original motivation for a mandatory linter sandbox image.

jwilger referenced this issue

2026-05-02 19:41:40 -07:00

Re-scope sandbox requirements after removing bundled linters #46

jwilger referenced this issue from a pull request that will close it,

2026-05-03 10:33:30 -07:00

feat(review): retire bundled linter execution #54

jwilger referenced this issue

2026-05-03 10:49:26 -07:00

feat(review): retire bundled linter execution #54

jwilger referenced this issue

2026-05-03 10:49:26 -07:00

feat(review): retire bundled linter execution #54