Drop review-time pre-merge checks #63

New issue

Closed

opened 2026-05-03 17:49:35 -07:00 by jwilger · 0 comments

jwilger commented

2026-05-03 17:49:35 -07:00

Owner

Context

The current set of "pre-merge checks" appears to be review-time behavior copied from reviewer products that try to compensate for projects without CI/CD. For auto_review, these checks are better handled by explicit CI/static-analysis jobs, or omitted entirely.

Specific concerns:

The CHANGELOG check is not needed. Not every PR should be required to update CHANGELOG.md; longer term, changelog management should move to a release automation tool such as release-plz. For now, deleting CHANGELOG.md entirely is acceptable.
The test-related pre-merge check should not be part of review output. Mutation testing should instead be added as part of CI.
The "no new TODO/FIXME markers" rule is better implemented as a static linter check in CI.
If the reviewer notices missing project checks, it should suggest adding CI jobs rather than performing these checks as review findings.

Proposed change

Drop the pre-merge-checks review behavior unless there is a concrete use case that still justifies keeping it.

Acceptance criteria

Pre-merge checks are no longer generated as part of automated review output.
CHANGELOG update enforcement is removed from review behavior.
Test-presence/pre-merge test checks are removed from review behavior, with mutation testing tracked/implemented as CI instead if needed.
TODO/FIXME marker checks are not emitted by the reviewer and are handled by CI/static linting if retained.
Documentation/configuration referencing pre-merge checks is removed or updated to explain the new approach.

## Context The current set of "pre-merge checks" appears to be review-time behavior copied from reviewer products that try to compensate for projects without CI/CD. For `auto_review`, these checks are better handled by explicit CI/static-analysis jobs, or omitted entirely. Specific concerns: - The CHANGELOG check is not needed. Not every PR should be required to update `CHANGELOG.md`; longer term, changelog management should move to a release automation tool such as `release-plz`. For now, deleting `CHANGELOG.md` entirely is acceptable. - The test-related pre-merge check should not be part of review output. Mutation testing should instead be added as part of CI. - The "no new TODO/FIXME markers" rule is better implemented as a static linter check in CI. - If the reviewer notices missing project checks, it should suggest adding CI jobs rather than performing these checks as review findings. ## Proposed change Drop the pre-merge-checks review behavior unless there is a concrete use case that still justifies keeping it. ## Acceptance criteria - Pre-merge checks are no longer generated as part of automated review output. - CHANGELOG update enforcement is removed from review behavior. - Test-presence/pre-merge test checks are removed from review behavior, with mutation testing tracked/implemented as CI instead if needed. - TODO/FIXME marker checks are not emitted by the reviewer and are handled by CI/static linting if retained. - Documentation/configuration referencing pre-merge checks is removed or updated to explain the new approach.

jwilger referenced this issue from a pull request that will close it,

2026-05-03 18:17:57 -07:00

fix(review): drop pre-merge checks #64

jwilger closed this issue

2026-05-03 18:23:59 -07:00

jwilger referenced this issue from a commit

2026-05-03 18:24:00 -07:00

fix(review): drop pre-merge checks (#64)