Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(review): drop pre-merge checks #64

Merged
jwilger merged 1 commit from fix/drop-pre-merge-checks-63 into main 2026-05-03 18:23:58 -07:00
Conversation 4 Commits 1 Files changed 20 +281 -1269
jwilger commented 2026-05-03 18:17:57 -07:00
Owner
Copy link

Summary

  • Remove review-time built-in and custom pre-merge check execution/emission from the semantic review pipeline.
  • Retire .auto_review.yaml pre_merge_checks support and delete the custom pre-merge prompt/schema path.
  • Update user/operator docs, examples, and templates to point merge-readiness checks at CI/static analysis instead.

Verification

  • nix develop -c cargo nextest run -p ar-review full_source_only_git_diff_with_no_findings_omits_pre_merge_checks_without_request_changes custom_pre_merge_checks_are_not_evaluated_or_emitted_for_no_finding_reviews
  • nix develop -c cargo nextest run -p ar-review -p ar-prompts -p ar-orchestrator --no-tests=pass
  • nix develop -c cargo fmt --all -- --check
  • nix develop -c cargo clippy --workspace --all-targets -- -D warnings

Closes #63.

## Summary - Remove review-time built-in and custom pre-merge check execution/emission from the semantic review pipeline. - Retire `.auto_review.yaml` `pre_merge_checks` support and delete the custom pre-merge prompt/schema path. - Update user/operator docs, examples, and templates to point merge-readiness checks at CI/static analysis instead. ## Verification - `nix develop -c cargo nextest run -p ar-review full_source_only_git_diff_with_no_findings_omits_pre_merge_checks_without_request_changes custom_pre_merge_checks_are_not_evaluated_or_emitted_for_no_finding_reviews` - `nix develop -c cargo nextest run -p ar-review -p ar-prompts -p ar-orchestrator --no-tests=pass` - `nix develop -c cargo fmt --all -- --check` - `nix develop -c cargo clippy --workspace --all-targets -- -D warnings` Closes #63.
fix(review): drop pre-merge checks
All checks were successful
CI / Nix flake check (pull_request) Successful in 1m59s
Details
auto_review auto_review: no findings
8f74200aee
auto-review requested changes 2026-05-03 18:18:22 -07:00
Dismissed
auto-review left a comment
Copy link

This PR removes the pre-merge checks from the review process, including both built-in and custom checks. The changes involve deleting related code, schemas, and documentation references. The PR appears safe to merge, but users should be informed about the removal of pre-merge checks and update their configurations accordingly.

Walkthrough

  • Configuration Changes

    • Removed pre_merge_checks from .auto_review.example.yaml.
    • Updated .forgejo/pull_request_template.md to reflect the removal of bot-run pre-merge checks.

  • Code Changes

    • Removed pre-merge check logic from run_review_job in dispatcher.rs.
    • Deleted pre_merge_custom.json schema and related code in ar-prompts.
    • Removed pre_merge and pre_merge_llm modules from ar-review.

  • Documentation Updates

    • Updated CHANGELOG.md to document the removal of pre-merge checks.
    • Removed references to pre-merge checks in README.md, USER-GUIDE.md, and other documentation files.

  • Testing

    • Updated tests to reflect the removal of pre-merge checks.

Pre-merge checks

  • CHANGELOG updated — CHANGELOG.md is in the diff
  • Tests touched — source changed but no test file appears in the diff
  • No new TODO/FIXME comments — 1 new TODO/FIXME marker in the diff
This PR removes the pre-merge checks from the review process, including both built-in and custom checks. The changes involve deleting related code, schemas, and documentation references. The PR appears safe to merge, but users should be informed about the removal of pre-merge checks and update their configurations accordingly. ## Walkthrough - **Configuration Changes** - Removed `pre_merge_checks` from `.auto_review.example.yaml`. - Updated `.forgejo/pull_request_template.md` to reflect the removal of bot-run pre-merge checks. - **Code Changes** - Removed pre-merge check logic from `run_review_job` in `dispatcher.rs`. - Deleted `pre_merge_custom.json` schema and related code in `ar-prompts`. - Removed `pre_merge` and `pre_merge_llm` modules from `ar-review`. - **Documentation Updates** - Updated `CHANGELOG.md` to document the removal of pre-merge checks. - Removed references to pre-merge checks in `README.md`, `USER-GUIDE.md`, and other documentation files. - **Testing** - Updated tests to reflect the removal of pre-merge checks. ## Pre-merge checks - [x] CHANGELOG updated — CHANGELOG.md is in the diff - [ ] Tests touched — source changed but no test file appears in the diff - [ ] No new TODO/FIXME comments — 1 new TODO/FIXME marker in the diff
jwilger commented 2026-05-03 18:23:22 -07:00
Author
Owner
Copy link

@auto_review re-review

@auto_review re-review
auto-review commented 2026-05-03 18:23:24 -07:00
Owner
Copy link

Queued a fresh review at 8f74200aee. Watch the commit-status badge for progress.

Queued a fresh review at 8f74200aeefb10ebebc8d615667729232fac00c6. Watch the commit-status badge for progress.
auto-review approved these changes 2026-05-03 18:23:36 -07:00
auto-review left a comment
Copy link

This PR removes the pre-merge checks from the review pipeline, including both built-in and custom checks. The changes appear safe to merge, but users should be informed about migrating these checks to CI or static analysis tools.

Walkthrough

  • Configuration Changes
    • Removed pre_merge_checks from .auto_review.example.yaml and related documentation.
  • Code Changes
    • Deleted files and code related to pre-merge checks, including pre_merge_custom.json, pre_merge_custom.rs, and related logic in dispatcher.rs and pipeline.rs.
  • Documentation Updates
    • Updated user guides and release notes to reflect the removal of pre-merge checks and the shift towards CI/static analysis for these checks.
This PR removes the pre-merge checks from the review pipeline, including both built-in and custom checks. The changes appear safe to merge, but users should be informed about migrating these checks to CI or static analysis tools. ## Walkthrough - **Configuration Changes** - Removed `pre_merge_checks` from `.auto_review.example.yaml` and related documentation. - **Code Changes** - Deleted files and code related to pre-merge checks, including `pre_merge_custom.json`, `pre_merge_custom.rs`, and related logic in `dispatcher.rs` and `pipeline.rs`. - **Documentation Updates** - Updated user guides and release notes to reflect the removal of pre-merge checks and the shift towards CI/static analysis for these checks.
jwilger deleted branch fix/drop-pre-merge-checks-63 2026-05-03 18:23:59 -07:00
jwilger referenced this pull request from a commit 2026-05-05 12:18:07 -07:00
chore: release v0.1.0 (#94)
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!64
No description provided.