docs: record single-binary ADRs #123

Merged

jwilger merged 1 commit from issue-115-single-binary-exploration into main

2026-05-06 12:09:25 -07:00

jwilger commented

2026-05-06 12:00:18 -07:00

Owner

Summary

Adds ADR-0005 to accept a breaking switch to one public auto-review executable, grouped domain commands, Docker image reuse of the same binary, and Linux binary release artifacts with full provenance.
Adds ADR-0006 to accept embedded youki/OCI gateway isolation as the default single-binary gateway mode, with explicit bare opt-out and fail-closed OCI startup behavior.
Links ADR-0002 to the new accepted decisions and records follow-up implementation issues #116–#122.

Verification

git diff --cached --check before commit

Closes #115

## Summary - Adds ADR-0005 to accept a breaking switch to one public `auto-review` executable, grouped domain commands, Docker image reuse of the same binary, and Linux binary release artifacts with full provenance. - Adds ADR-0006 to accept embedded `youki`/OCI gateway isolation as the default single-binary gateway mode, with explicit bare opt-out and fail-closed OCI startup behavior. - Links ADR-0002 to the new accepted decisions and records follow-up implementation issues #116–#122. ## Verification - `git diff --cached --check` before commit Closes #115

jwilger added 1 commit

2026-05-06 12:00:18 -07:00

docs: record single-binary ADRs

CI / Nix flake check (pull_request) Successful in 6s

Details

CI / auto_review semantic review (pull_request) Successful in 1s

Details

auto_review auto_review: no findings

Publish release / release-publish (pull_request) Has been skipped

Details

8ffd224932

Capture the accepted CLI, release, and embedded OCI isolation decisions from issue #115 as ADRs so implementation can proceed in focused follow-up issues.

auto-review approved these changes

2026-05-06 12:01:00 -07:00

auto-review left a comment

This PR adds two new ADRs documenting significant changes: a switch to a single public executable for auto-review and the adoption of embedded OCI gateway isolation. These changes are well-documented and appear to be thoughtfully planned, with clear implementation steps and consequences outlined.

Walkthrough

docs/ADR-0002-sandbox.md:
- Updated to reference new ADRs (0005 and 0006) that document decisions related to a single binary and gateway isolation.
docs/ADR-0005-single-public-executable.md:
- Introduces a breaking change to consolidate auto-review into a single executable with grouped commands.
- Details the rationale, decision, and consequences of this change, including the impact on operators and deployment.
docs/ADR-0006-embedded-oci-gateway-isolation.md:
- Describes the decision to use embedded OCI isolation for the single binary, enhancing security and operational safety.
- Outlines the implementation strategy and security boundaries, ensuring that the gateway remains secure and reliable.

This PR adds two new ADRs documenting significant changes: a switch to a single public executable for `auto-review` and the adoption of embedded OCI gateway isolation. These changes are well-documented and appear to be thoughtfully planned, with clear implementation steps and consequences outlined. ## Walkthrough - **docs/ADR-0002-sandbox.md**: - Updated to reference new ADRs (0005 and 0006) that document decisions related to a single binary and gateway isolation. - **docs/ADR-0005-single-public-executable.md**: - Introduces a breaking change to consolidate `auto-review` into a single executable with grouped commands. - Details the rationale, decision, and consequences of this change, including the impact on operators and deployment. - **docs/ADR-0006-embedded-oci-gateway-isolation.md**: - Describes the decision to use embedded OCI isolation for the single binary, enhancing security and operational safety. - Outlines the implementation strategy and security boundaries, ensuring that the gateway remains secure and reliable.

jwilger merged commit 0754c0ebea into main

2026-05-06 12:09:25 -07:00

jwilger referenced this pull request from a commit

2026-05-06 12:09:27 -07:00

docs: record single-binary ADRs (#123)