Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(release): push release branch inside Nix #230

Merged
jwilger merged 1 commit from fix/release-prepare-ci into main 2026-05-16 22:54:34 -07:00
Conversation 1 Commits 1 Files changed 1 +1 -1
jwilger commented 2026-05-16 22:41:35 -07:00
Owner
Copy link

Summary

  • run the release-prepare branch push through nix develop --command so lefthook pre-push can find just

Verification

  • rtk git diff --check -- .forgejo/workflows/release-prepare.yml
  • nix develop --command just --version
  • pre-push hook during branch push ran just ci successfully
## Summary - run the release-prepare branch push through `nix develop --command` so lefthook pre-push can find `just` ## Verification - `rtk git diff --check -- .forgejo/workflows/release-prepare.yml` - `nix develop --command just --version` - pre-push hook during branch push ran `just ci` successfully
fix(release): push release branch inside Nix
All checks were successful
CI / Format check (pull_request) Successful in 6s
Details
CI / Clippy (pull_request) Successful in 41s
Details
CI / Dependency policy (pull_request) Successful in 11s
Details
CI / Test (pull_request) Successful in 53s
Details
CI / Build (pull_request) Successful in 33s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
CI / Publish PR artifact packages (pull_request) Successful in 2s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
5d42295635
auto-review approved these changes 2026-05-16 22:54:17 -07:00
auto-review left a comment
Copy link

The PR modifies the release workflow to run the git push command within a Nix environment, ensuring that the lefthook pre-push can find just. This change appears safe to merge, assuming the Nix environment is correctly configured.

Walkthrough

  • .forgejo/workflows/release-prepare.yml:
    • The git push command is now executed within a Nix environment using nix develop --command. This ensures that the lefthook pre-push can find just, which is necessary for the release process.
The PR modifies the release workflow to run the `git push` command within a Nix environment, ensuring that the lefthook pre-push can find `just`. This change appears safe to merge, assuming the Nix environment is correctly configured. ## Walkthrough - **.forgejo/workflows/release-prepare.yml**: - The `git push` command is now executed within a Nix environment using `nix develop --command`. This ensures that the lefthook pre-push can find `just`, which is necessary for the release process.
jwilger deleted branch fix/release-prepare-ci 2026-05-16 22:54:34 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!230
No description provided.