Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(release): keep release prep metadata-only #238

Merged
jwilger merged 4 commits from fix/release-prepare-skip-checks into main 2026-05-17 20:18:07 -07:00
Conversation 2 Commits 4 Files changed 2 +97 -22
jwilger commented 2026-05-17 19:59:24 -07:00
Owner
Copy link

Summary

  • keep cargo semver-checks in release-prep as release-type planning input for semver-aware version bumps
  • push generated release branches with --no-verify so local pre-push hooks do not run full verification
  • read open release PRs from Forgejo API JSON instead of tea pr ls output before jq filtering
  • write the API-derived PR list to a temp file inside the Nix command and load open_prs from that file so Nix stdout chatter cannot corrupt jq input

Verification

  • rtk cargo test -p ar-gateway --test ci_workflow_contract
  • rtk just fmt
## Summary - keep `cargo semver-checks` in release-prep as release-type planning input for semver-aware version bumps - push generated release branches with `--no-verify` so local pre-push hooks do not run full verification - read open release PRs from Forgejo API JSON instead of `tea pr ls` output before `jq` filtering - write the API-derived PR list to a temp file inside the Nix command and load `open_prs` from that file so Nix stdout chatter cannot corrupt jq input ## Verification - `rtk cargo test -p ar-gateway --test ci_workflow_contract` - `rtk just fmt`
fix(release): read release PRs from Forgejo API
All checks were successful
CI / Format check (pull_request) Successful in 5s
Details
CI / Clippy (pull_request) Successful in 40s
Details
CI / Dependency policy (pull_request) Successful in 10s
Details
CI / Test (pull_request) Successful in 51s
Details
CI / Build (pull_request) Successful in 33s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
auto_review auto_review: 1 warning
8117cf1000
auto-review approved these changes 2026-05-17 20:00:59 -07:00
Dismissed
auto-review left a comment
Copy link

The PR removes release verification checks from the release-prepare job and updates the method for querying open PRs using the Forgejo API. It appears safe to merge, but ensure that the removal of checks does not impact critical validation processes.

Walkthrough

  • .forgejo/workflows/release-prepare.yml:
    • Removed cargo semver-checks from the release-prepare job, simplifying the release process by focusing on metadata updates.
    • Updated the method for querying open PRs to use the Forgejo API directly, improving reliability and reducing dependency on external tools.
    • Added --no-verify to git push to bypass local hooks, ensuring a smoother CI/CD pipeline.
  • crates/ar-gateway/tests/ci_workflow_contract.rs:
    • Added tests to verify that the release-prepare job only updates metadata and does not perform release checks.
    • Confirmed that the push operation bypasses local hooks and that the Forgejo API is used for PR lookups.
The PR removes release verification checks from the release-prepare job and updates the method for querying open PRs using the Forgejo API. It appears safe to merge, but ensure that the removal of checks does not impact critical validation processes. ## Walkthrough - **.forgejo/workflows/release-prepare.yml**: - Removed `cargo semver-checks` from the release-prepare job, simplifying the release process by focusing on metadata updates. - Updated the method for querying open PRs to use the Forgejo API directly, improving reliability and reducing dependency on external tools. - Added `--no-verify` to `git push` to bypass local hooks, ensuring a smoother CI/CD pipeline. - **crates/ar-gateway/tests/ci_workflow_contract.rs**: - Added tests to verify that the release-prepare job only updates metadata and does not perform release checks. - Confirmed that the push operation bypasses local hooks and that the Forgejo API is used for PR lookups.
.forgejo/workflows/release-prepare.yml Outdated
auto-review commented 2026-05-17 20:00:59 -07:00
Owner
Copy link

🟡 Warning: The removal of the cargo semver-checks verification from the release-prepare job is intentional, but ensure that this does not affect any critical release validation processes that might be necessary for your workflow.

🟡 **Warning:** The removal of the `cargo semver-checks` verification from the release-prepare job is intentional, but ensure that this does not affect any critical release validation processes that might be necessary for your workflow.
jwilger commented 2026-05-17 20:12:26 -07:00
Author
Owner
Copy link

That was a mistake. Just fixed it.

That was a mistake. Just fixed it.
jwilger marked this conversation as resolved
fix(release): restore semver release planning
All checks were successful
CI / Format check (pull_request) Successful in 6s
Details
CI / Clippy (pull_request) Successful in 40s
Details
CI / Dependency policy (pull_request) Successful in 10s
Details
CI / Test (pull_request) Successful in 51s
Details
CI / Build (pull_request) Successful in 32s
Details
CI / Request auto_review semantic review (pull_request) Successful in 1s
Details
CI / Build PR artifacts (no token) (pull_request) Successful in 2s
Details
auto_review auto_review: no findings
739ed4342b
jwilger dismissed auto-review's review 2026-05-17 20:10:50 -07:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

auto-review approved these changes 2026-05-17 20:12:23 -07:00
auto-review left a comment
Copy link

The PR enhances the release preparation workflow by integrating cargo semver-checks for semver-aware version bumps and modifies the push command to bypass local hooks. It also updates the test suite to reflect these changes, ensuring the workflow behaves as expected.

Walkthrough

Δ since 8117cf1:

  • .forgejo/workflows/release-prepare.yml:
    • Added logic to determine the minimum release type using cargo semver-checks against a baseline tag.
    • Updated the push command to use --no-verify to bypass local hooks.
  • crates/ar-gateway/tests/ci_workflow_contract.rs:
    • Updated the test release_prepare_uses_semver_checks_for_release_type_planning to check for the presence of cargo semver-checks and the correct handling of release types.
The PR enhances the release preparation workflow by integrating `cargo semver-checks` for semver-aware version bumps and modifies the push command to bypass local hooks. It also updates the test suite to reflect these changes, ensuring the workflow behaves as expected. ## Walkthrough ### Δ since 8117cf1: - **.forgejo/workflows/release-prepare.yml**: - Added logic to determine the minimum release type using `cargo semver-checks` against a baseline tag. - Updated the push command to use `--no-verify` to bypass local hooks. - **crates/ar-gateway/tests/ci_workflow_contract.rs**: - Updated the test `release_prepare_uses_semver_checks_for_release_type_planning` to check for the presence of `cargo semver-checks` and the correct handling of release types.
jwilger deleted branch fix/release-prepare-skip-checks 2026-05-17 20:18:07 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!238
No description provided.