fix(release): render release PR descriptions correctly #242

Merged

jwilger merged 2 commits from fix/release-pr-description-quality into main

2026-05-17 23:38:46 -07:00

jwilger commented

2026-05-17 23:36:12 -07:00

Owner

Summary

Render generated release PR descriptions as normal Markdown paragraphs instead of code blocks.
Add a release-prepare workflow contract test for generated PR descriptions.
Accept the current generated release PR body in the deterministic metadata bypass so Cheap-tier false negatives do not block release PRs.

Verification

just fmt
rtk cargo test -p ar-gateway --test ci_workflow_contract
rtk cargo test -p ar-review generated_release_pr_metadata_does_not_request_changes_when_cheap_model_over_blocks
rtk cargo test -p ar-review
just clippy

## Summary - Render generated release PR descriptions as normal Markdown paragraphs instead of code blocks. - Add a release-prepare workflow contract test for generated PR descriptions. - Accept the current generated release PR body in the deterministic metadata bypass so Cheap-tier false negatives do not block release PRs. ## Verification - `just fmt` - `rtk cargo test -p ar-gateway --test ci_workflow_contract` - `rtk cargo test -p ar-review generated_release_pr_metadata_does_not_request_changes_when_cheap_model_over_blocks` - `rtk cargo test -p ar-review` - `just clippy`

jwilger added 2 commits

2026-05-17 23:36:12 -07:00

fix(release): render release PR descriptions as paragraphs d9c42de5fa

fix(review): accept generated release PR metadata

CI / Format check (pull_request) Successful in 6s

Details

CI / Clippy (pull_request) Successful in 39s

Details

CI / Dependency policy (pull_request) Successful in 12s

Details

CI / Test (pull_request) Successful in 51s

Details

CI / Build (pull_request) Successful in 31s

Details

CI / Request auto_review semantic review (pull_request) Successful in 1s

Details

CI / Build PR artifacts (no token) (pull_request) Successful in 2s

Details

auto_review auto_review: no findings

97fcb27b8e

auto-review approved these changes

2026-05-17 23:37:48 -07:00

auto-review left a comment

Walkthrough

.forgejo/workflows/release-prepare.yml:
- Adjusted the indentation of the release PR description to ensure it is rendered as a Markdown paragraph instead of a code block.
crates/ar-gateway/tests/ci_workflow_contract.rs:
- Added a test to verify that release PR descriptions are correctly formatted as Markdown paragraphs.
- Introduced a helper function release_pr_descriptions to extract and verify PR descriptions from the workflow script.
crates/ar-review/src/pipeline.rs:
- Updated the logic to recognize both old and new formats of the release PR body to ensure backward compatibility.

This PR updates the release PR description format from code blocks to Markdown paragraphs and adds tests to ensure correct rendering. It also modifies the release-prepare workflow to accommodate these changes. The changes appear safe to merge. ## Walkthrough - **.forgejo/workflows/release-prepare.yml**: - Adjusted the indentation of the release PR description to ensure it is rendered as a Markdown paragraph instead of a code block. - **crates/ar-gateway/tests/ci_workflow_contract.rs**: - Added a test to verify that release PR descriptions are correctly formatted as Markdown paragraphs. - Introduced a helper function `release_pr_descriptions` to extract and verify PR descriptions from the workflow script. - **crates/ar-review/src/pipeline.rs**: - Updated the logic to recognize both old and new formats of the release PR body to ensure backward compatibility.

jwilger merged commit 5acc5d6bf4 into main

2026-05-17 23:38:46 -07:00

jwilger deleted branch fix/release-pr-description-quality

2026-05-17 23:38:47 -07:00

jwilger referenced this pull request from a commit

2026-05-17 23:38:48 -07:00

fix(release): render release PR descriptions correctly (#242)