Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

feat(review): suggest missing CI linters #65

Merged
jwilger merged 1 commit from issue-51-ci-linter-advisories into main 2026-05-03 18:47:17 -07:00
Conversation 4 Commits 1 Files changed 3 +152
jwilger commented 2026-05-03 18:33:37 -07:00
Owner
Copy link

Summary

  • Add default review guidance to recommend missing CI linter/static-check coverage as warning-level findings.
  • Instruct reviews to name the absent check and CI gate, suppressing warning-level repeats when project memory says maintainers declined the check.
  • Cover both default advisory and memory-declined suppression prompt behavior.

Verification

  • nix develop -c cargo test -p ar-review missing_ci_linter -- --nocapture
  • nix develop -c cargo fmt --all -- --check
  • nix develop -c cargo test -p ar-review
  • nix develop -c cargo clippy -p ar-prompts -p ar-review --all-targets -- -D warnings
  • nix develop -c cargo test -p ar-prompts

Closes #51.

## Summary - Add default review guidance to recommend missing CI linter/static-check coverage as warning-level findings. - Instruct reviews to name the absent check and CI gate, suppressing warning-level repeats when project memory says maintainers declined the check. - Cover both default advisory and memory-declined suppression prompt behavior. ## Verification - `nix develop -c cargo test -p ar-review missing_ci_linter -- --nocapture` - `nix develop -c cargo fmt --all -- --check` - `nix develop -c cargo test -p ar-review` - `nix develop -c cargo clippy -p ar-prompts -p ar-review --all-targets -- -D warnings` - `nix develop -c cargo test -p ar-prompts` Closes #51.
feat(review): suggest missing CI linters
All checks were successful
CI / Nix flake check (pull_request) Successful in 1m58s
Details
auto_review auto_review: no findings
93c67ae892
auto-review approved these changes 2026-05-03 18:35:18 -07:00
Dismissed
auto-review left a comment
Copy link

This PR introduces a feature to suggest missing CI linters in reviews, with the ability to suppress warnings for checks that maintainers have declined. The changes appear well-implemented and include tests to verify the new behavior. It seems safe to merge.

Walkthrough

  • CHANGELOG.md: Updated to include a summary of the new feature that suggests missing CI linters and suppresses warnings for declined checks.
  • crates/ar-prompts/src/prompt.rs: Added a new section to the review prompt to guide the emission of findings related to missing CI linters.
  • crates/ar-review/src/pipeline.rs: Implemented tests to verify the new feature, ensuring that missing CI linters are suggested and that warnings are suppressed when maintainers have declined certain checks.
This PR introduces a feature to suggest missing CI linters in reviews, with the ability to suppress warnings for checks that maintainers have declined. The changes appear well-implemented and include tests to verify the new behavior. It seems safe to merge. ## Walkthrough - **CHANGELOG.md**: Updated to include a summary of the new feature that suggests missing CI linters and suppresses warnings for declined checks. - **crates/ar-prompts/src/prompt.rs**: Added a new section to the review prompt to guide the emission of findings related to missing CI linters. - **crates/ar-review/src/pipeline.rs**: Implemented tests to verify the new feature, ensuring that missing CI linters are suggested and that warnings are suppressed when maintainers have declined certain checks.
jwilger commented 2026-05-03 18:36:28 -07:00
Author
Owner
Copy link

@auto_review re-review

@auto_review re-review
auto-review commented 2026-05-03 18:36:28 -07:00
Owner
Copy link

Queued a fresh review at 93c67ae892. Watch the commit-status badge for progress.

Queued a fresh review at 93c67ae89299e8d102342de7a7dafee339f887f4. Watch the commit-status badge for progress.
auto-review approved these changes 2026-05-03 18:36:35 -07:00
auto-review left a comment
Copy link

This PR introduces a feature to suggest missing CI linters in reviews, with the ability to suppress recommendations for checks that maintainers have declined. The changes include updates to the review prompt and new test cases to verify the functionality. The implementation appears sound, but ensure comprehensive test coverage for various CI configurations and scenarios.

Walkthrough

  • CHANGELOG.md:
    • Added an entry describing the new feature for CI coverage review guidance.
  • crates/ar-prompts/src/prompt.rs:
    • Updated the review prompt to include guidance on missing CI linters and checks.
  • crates/ar-review/src/pipeline.rs:
    • Added test cases to verify the new feature, ensuring that missing CI linters are recommended and declined checks are not repeatedly suggested.
This PR introduces a feature to suggest missing CI linters in reviews, with the ability to suppress recommendations for checks that maintainers have declined. The changes include updates to the review prompt and new test cases to verify the functionality. The implementation appears sound, but ensure comprehensive test coverage for various CI configurations and scenarios. ## Walkthrough - **CHANGELOG.md**: - Added an entry describing the new feature for CI coverage review guidance. - **crates/ar-prompts/src/prompt.rs**: - Updated the review prompt to include guidance on missing CI linters and checks. - **crates/ar-review/src/pipeline.rs**: - Added test cases to verify the new feature, ensuring that missing CI linters are recommended and declined checks are not repeatedly suggested.
jwilger referenced this pull request from a commit 2026-05-05 12:18:07 -07:00
chore: release v0.1.0 (#94)
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!65
No description provided.