Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

feat(actions): add Forgejo CI action and quiet compare fallback #69

Merged
jwilger merged 4 commits from issue-43-forgejo-ci-review-action into main 2026-05-04 07:23:34 -07:00
Conversation 2 Commits 4 Files changed 1 +42 -3
jwilger commented 2026-05-04 07:13:19 -07:00
Owner
Copy link

Summary

  • Add the Forgejo CI review gateway action packaging, docs, flake wiring, and contract coverage.
  • Quiet the known benign Forgejo compare-diff missing-target fallback to INFO so normal incremental-review recovery does not spam WARN logs.
  • Preserve WARN logging for unexpected compare-diff failures, including unrelated 404 responses.

Verification

  • nix develop -c cargo fmt --all -- --check
  • nix develop -c cargo nextest run -p ar-orchestrator compare_diff
  • nix develop -c cargo nextest run -p ar-orchestrator
## Summary - Add the Forgejo CI review gateway action packaging, docs, flake wiring, and contract coverage. - Quiet the known benign Forgejo compare-diff missing-target fallback to INFO so normal incremental-review recovery does not spam WARN logs. - Preserve WARN logging for unexpected compare-diff failures, including unrelated 404 responses. ## Verification - `nix develop -c cargo fmt --all -- --check` - `nix develop -c cargo nextest run -p ar-orchestrator compare_diff` - `nix develop -c cargo nextest run -p ar-orchestrator`
feat(actions): add CI review gateway action
Some checks failed
auto_review auto_review: no findings
CI / Nix flake check (pull_request) Failing after 48s
Details
3a052dfca0
fix(ci): include Forgejo action contract asset
All checks were successful
auto_review auto_review: no findings
CI / Nix flake check (pull_request) Successful in 2m31s
Details
a75bb150c5
fix(orchestrator): quiet benign compare diff fallbacks
All checks were successful
auto_review auto_review: no findings
CI / Nix flake check (pull_request) Successful in 2m32s
Details
72fe81802d
auto-review approved these changes 2026-05-04 07:13:36 -07:00
Dismissed
auto-review left a comment
Copy link

This PR introduces a new Forgejo CI review gateway action, updates documentation, and modifies error handling in the dispatcher. The changes appear well-structured and include tests for new functionality, but ensure that all breaking changes are communicated to users.

Walkthrough

  • New Rule File: A new rule file .kilo/rules/branch-first.md is added, but it is not referenced in any documentation. Consider adding references to ensure visibility.
  • Changelog Updates: The changelog mentions closing issue #43, but this is not referenced in the PR description. Ensure traceability by linking issues in the PR.
  • Tests: The test forgejo_action_posts_ci_review_to_gateway is comprehensive but could benefit from comments for clarity. The new function compare_diff_fallback_level is tested for specific error scenarios, but additional tests could improve coverage.
  • Action Refactoring: The action.yml file has been refactored to remove legacy inputs and streamline the action. This is a breaking change, so ensure users are informed and update dependent workflows.
This PR introduces a new Forgejo CI review gateway action, updates documentation, and modifies error handling in the dispatcher. The changes appear well-structured and include tests for new functionality, but ensure that all breaking changes are communicated to users. ## Walkthrough - **New Rule File**: A new rule file `.kilo/rules/branch-first.md` is added, but it is not referenced in any documentation. Consider adding references to ensure visibility. - **Changelog Updates**: The changelog mentions closing issue #43, but this is not referenced in the PR description. Ensure traceability by linking issues in the PR. - **Tests**: The test `forgejo_action_posts_ci_review_to_gateway` is comprehensive but could benefit from comments for clarity. The new function `compare_diff_fallback_level` is tested for specific error scenarios, but additional tests could improve coverage. - **Action Refactoring**: The `action.yml` file has been refactored to remove legacy inputs and streamline the action. This is a breaking change, so ensure users are informed and update dependent workflows.
Merge branch 'main' into issue-43-forgejo-ci-review-action
All checks were successful
auto_review auto_review: no findings
CI / Nix flake check (pull_request) Successful in 6s
Details
7687c0d355
auto-review approved these changes 2026-05-04 07:17:13 -07:00
auto-review left a comment
Copy link

This PR introduces a new Forgejo CI review gateway action and modifies error handling for specific 404 errors in the dispatcher. The changes appear well-structured and include tests for the new functionality, making it safe to merge.

Walkthrough

  • Error Handling Changes:
    • The dispatcher now logs specific 404 errors as INFO instead of WARN, which helps differentiate between expected and unexpected failures.
    • A new function compare_diff_fallback_level determines the logging level based on the error content.
  • Testing:
    • New tests ensure that the compare_diff_fallback_level function behaves as expected for different error scenarios.
This PR introduces a new Forgejo CI review gateway action and modifies error handling for specific 404 errors in the dispatcher. The changes appear well-structured and include tests for the new functionality, making it safe to merge. ## Walkthrough - **Error Handling Changes**: - The dispatcher now logs specific 404 errors as INFO instead of WARN, which helps differentiate between expected and unexpected failures. - A new function `compare_diff_fallback_level` determines the logging level based on the error content. - **Testing**: - New tests ensure that the `compare_diff_fallback_level` function behaves as expected for different error scenarios.
jwilger changed title from feat(actions): add Forgejo CI review gateway action to feat(actions): add Forgejo CI action and quiet compare fallback 2026-05-04 07:22:06 -07:00
jwilger referenced this pull request from a commit 2026-05-05 12:18:07 -07:00
chore: release v0.1.0 (#94)
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!69
No description provided.