feat(actions): wire CI semantic review job #70
No reviewers
Labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Slipstream/auto_review!70
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-43-ci-review-action"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
semantic-reviewForgejo Actions job that runs afterflake-checkand invokesdeploy/forgejo-action.Verification
nix develop --command cargo fmt --all -- --checknix develop --command cargo test -p ar-gateway --test forgejo_action_contractnix develop --command cargo clippy -p ar-gateway --test forgejo_action_contract -- -D warningsCloses #43.
This PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob and uses thedeploy/forgejo-action. It also adds a contract test to ensure the CI review wiring remains intact. The changes appear well-structured and safe to merge.Walkthrough
.forgejo/workflows/ci.yml:
semantic-reviewjob that runs afterflake-check.deploy/forgejo-actionand passes necessary parameters likegateway-urlandaction-tokenfrom secrets.crates/ar-gateway/tests/forgejo_action_contract.rs:
🟡 Warning: Lines 13–21: Ensure that the
gateway-urlandaction-tokenare securely passed from secrets or environment variables to avoid exposing sensitive information.Updated PR #70 to remove the CI workflow contract test. The workflow wiring remains, but CI definition changes are no longer enforced through the Rust action contract test.
Verification after the fix:
nix develop --command cargo fmt --all -- --checknix develop --command cargo test -p ar-gateway --test forgejo_action_contractThis PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob and uses thedeploy/forgejo-actionto request a semantic review. The changes appear safe to merge, with minor suggestions for improvement.New commits pushed, approval review dismissed automatically according to repository settings
This PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob and uses thedeploy/forgejo-action. The changes appear well-structured and safe to merge, enhancing the CI process by automating semantic reviews post successful checks.Walkthrough
semantic-reviewthat depends on theflake-checkjob.deploy/forgejo-actionto request a review.semantic-reviewjob in the CI process, noting its execution afterflake-checkpasses.Pushed a fix for the failing review job.
The workflow was referencing the action with a Forgejo URL plus subdirectory (
https://git.johnwilger.com/jwilger/auto_review/deploy/forgejo-action@main). Forgejo Actions was failing before the normal checks could run. Since the job already checks out this PR, it now uses the local composite action path instead:Verification:
nix develop --command cargo fmt --all -- --checkNew commits pushed, approval review dismissed automatically according to repository settings
Pushed another CI fix.
The review job now treats the auto_review gateway configuration as optional for this repository workflow: if
AUTO_REVIEW_GATEWAY_URLorAUTO_REVIEW_ACTION_TOKENis not configured as an Actions secret, the job prints a skip message and exits successfully instead of failing CI. When both secrets are present, it checks out the PR and runs./deploy/forgejo-action.Verification:
nix develop --command cargo fmt --all -- --checkThis PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob. The changes appear well-structured and safe to merge, ensuring that semantic reviews are only triggered when necessary.Walkthrough
semantic-reviewis added to the CI workflow.flake-checkjob, ensuring that semantic reviews are only conducted if the prerequisite checks pass.AUTO_REVIEW_GATEWAY_URLandAUTO_REVIEW_ACTION_TOKEN) are not set, preventing unnecessary failures.semantic-reviewjob in the CI process, providing clear documentation of the change.New commits pushed, approval review dismissed automatically according to repository settings
This PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob. The changes appear safe to merge, but ensure that the prerequisites and configurations are correctly set up.Walkthrough
semantic-reviewis added to the CI workflow. It runs after theflake-checkjob and is conditioned to execute only on pull request events.deploy/forgejo-actionto request a semantic review.semantic-reviewjob in the CI workflow, noting that it runs afterflake-checkpasses.Pushed another CI guard.
The configured
AUTO_REVIEW_GATEWAY_URLcurrently came fromFORGEJO_BASE_URL(https://git.johnwilger.com), which is the Forgejo server, not thear-gatewayservice exposingPOST /reviews/ci. That makes the review action call the wrong host and fail the job.The workflow now skips semantic review when
AUTO_REVIEW_GATEWAY_URL == github.server_url, with a clear message. Once the real publicar-gatewaybase URL and matching CI review token are configured, the same job will run the action.Verification:
nix develop --command cargo fmt --all -- --checkNew commits pushed, approval review dismissed automatically according to repository settings
This PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob. It also updates thedeploy/forgejo-actionto include timeout options forcurlrequests. The changes appear well-structured and safe to merge, provided the necessary secrets are configured.Walkthrough
.forgejo/workflows/ci.yml:
semantic-reviewthat depends onflake-check.deploy/forgejo-action/action.yml:
curlcommand to include--connect-timeoutand--max-timeoptions, improving the robustness of network requests by preventing indefinite hangs.CHANGELOG.md:
semantic-reviewjob in the CI process.🟡 Warning: Ensure that the
AUTO_REVIEW_GATEWAY_URLandAUTO_REVIEW_ACTION_TOKENsecrets are correctly configured in the repository settings to avoid skipping the semantic review step.Pushed a timeout guard for the CI review action.
The latest head run (#115) is green and has an official auto_review approval on commit
3f5db8d. The apparent hang was from an older run against9e9ce72after changing the gateway URL to172.17.0.1; that path can stall if the runner can route to the host but the dev gateway is not listening on that interface.The action now bounds the gateway request:
Verification:
nix develop --command cargo fmt --all -- --checknix develop --command cargo test -p ar-gateway --test forgejo_action_contractThis PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob. It also updates the changelog to reflect this addition. The changes appear safe to merge, with a minor suggestion to add a timeout to thecurlcommand in the action configuration.Walkthrough
semantic-reviewis added to the CI workflow, which runs afterflake-checkand is conditioned on the presence of specific secrets.semantic-reviewjob in the CI workflow.curlcommand now includes--connect-timeoutand--max-timeoptions to prevent indefinite hanging.New commits pushed, approval review dismissed automatically according to repository settings
Pushed a workflow fix for the gateway reachability issue.
The runner config had
--network host, and a manual Docker host-network probe can connect tolocalhost:8090, but the Forgejo job still could not reach the gateway from thedockerlabel. The semantic review job now runs on the runner'snativelabel instead of the containerizeddockerlabel, soAUTO_REVIEW_GATEWAY_URL=http://localhost:8090resolves on the runner host where the dev gateway is listening.Verification:
nix develop --command cargo fmt --all -- --checkThis PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob and uses thedeploy/forgejo-action. The changes appear well-structured and safe to merge, with minor suggestions for improvement.Walkthrough
.forgejo/workflows/ci.yml:
semantic-reviewthat runs afterflake-check.deploy/forgejo-actionto request a semantic review.CHANGELOG.md:
deploy/forgejo-action/action.yml:
New commits pushed, approval review dismissed automatically according to repository settings
Pushed a fix for the 400 from
/reviews/ci.The gateway log showed:
The action was serializing
pr_numberas a JSON string. It now sends it as a JSON number:Updated the action contract test to enforce that shape.
Verification:
nix develop --command cargo fmt --all -- --checknix develop --command cargo test -p ar-gateway --test forgejo_action_contractThis PR introduces a new
semantic-reviewjob in the CI workflow, which runs after theflake-checkjob. The changes appear well-structured and safe to merge, with the main concern being the correct configuration of required secrets.Walkthrough
semantic-reviewthat runs afterflake-check.semantic-reviewjob in the CI process.pr_numberas a number instead of a string.curlcommand to improve reliability.🟡 Warning: Ensure that the
AUTO_REVIEW_GATEWAY_URLandAUTO_REVIEW_ACTION_TOKENsecrets are correctly configured in the repository settings to avoid skipping the semantic review step.