Slipstream/auto_review

Fork 0

fix(gateway): gate semantic reviews behind CI #72

Merged

jwilger merged 3 commits from fix/issue-44-ci-gated-reviews into main

2026-05-04 12:20:49 -07:00

jwilger commented

2026-05-04 11:10:27 -07:00

Owner

Summary

Stop ordinary pull_request webhooks, including opened/synchronized and bot review_requested events, from dispatching semantic ReviewJobs by default.
Keep CI-triggered /reviews/ci dispatch and explicit @auto_review re-review forced reviews, with re-review status explaining the intentional CI-gating bypass.
Update operator/deployment docs and CI-token wiring for the new webhook-intake vs CI-dispatch lifecycle.

Verification

nix develop -c cargo fmt --all -- --check
nix develop -c cargo nextest run -p ar-gateway -E 'test(valid_pr_opened_and_synchronized_are_accepted_without_dispatching_review) | test(review_requested_for_configured_bot_is_accepted_without_dispatching_review) | test(metrics_track_pr_webhook_intake_without_review_dispatch) | test(webhook_dedup_replies_ok_without_dispatching_on_retry) | test(webhook_dedup_passes_through_when_no_delivery_header) | test(ci_review_endpoint_fetches_matching_pr_and_dispatches_review_job)'
nix develop -c cargo nextest run -p ar-chat -E 'test(re_review_with_dispatcher_queues_force_job) | test(remember_stores_learning_and_replies_with_id)'
nix develop -c cargo nextest run -p ar-gateway -p ar-chat --no-tests=pass
nix develop -c cargo clippy --workspace --all-targets -- -D warnings

Skipped: helm template validation because helm is not installed in the Nix dev shell.

Closes #44.

## Summary - Stop ordinary pull_request webhooks, including opened/synchronized and bot review_requested events, from dispatching semantic ReviewJobs by default. - Keep CI-triggered /reviews/ci dispatch and explicit @auto_review re-review forced reviews, with re-review status explaining the intentional CI-gating bypass. - Update operator/deployment docs and CI-token wiring for the new webhook-intake vs CI-dispatch lifecycle. ## Verification - nix develop -c cargo fmt --all -- --check - nix develop -c cargo nextest run -p ar-gateway -E 'test(valid_pr_opened_and_synchronized_are_accepted_without_dispatching_review) | test(review_requested_for_configured_bot_is_accepted_without_dispatching_review) | test(metrics_track_pr_webhook_intake_without_review_dispatch) | test(webhook_dedup_replies_ok_without_dispatching_on_retry) | test(webhook_dedup_passes_through_when_no_delivery_header) | test(ci_review_endpoint_fetches_matching_pr_and_dispatches_review_job)' - nix develop -c cargo nextest run -p ar-chat -E 'test(re_review_with_dispatcher_queues_force_job) | test(remember_stores_learning_and_replies_with_id)' - nix develop -c cargo nextest run -p ar-gateway -p ar-chat --no-tests=pass - nix develop -c cargo clippy --workspace --all-targets -- -D warnings Skipped: helm template validation because helm is not installed in the Nix dev shell. Closes #44.

jwilger added 1 commit

2026-05-04 11:10:27 -07:00

fix(gateway): gate semantic reviews behind CI

CI / Nix flake check (pull_request) Failing after 2m31s

Details

CI / auto_review semantic review (pull_request) Has been skipped

Details

4d8e070bc7

jwilger added 1 commit

2026-05-04 11:27:23 -07:00

chore(dev): include helm in dev shell

CI / Nix flake check (pull_request) Failing after 1m44s

Details

CI / auto_review semantic review (pull_request) Has been skipped

Details

6250861d59

jwilger added 1 commit

2026-05-04 11:42:23 -07:00

test(orchestrator): drive synthetic e2e through CI endpoint

CI / Nix flake check (pull_request) Successful in 2m31s

Details

CI / auto_review semantic review (pull_request) Successful in 1s

Details

auto_review auto_review: no findings

bf980be84e

auto-review approved these changes

2026-05-04 11:45:53 -07:00

auto-review left a comment

Walkthrough

Documentation Updates:
- Updated various markdown files to reflect the new CI-gated review process, ensuring users understand the new workflow.
- Added instructions for setting up CI tokens and triggering reviews via CI workflows.
Code Changes:
- Modified ar-gateway to accept PR webhooks without dispatching reviews, aligning with the new CI-gated process.
- Updated ar-chat to include messages about bypassing CI gating for forced reviews.
Test Updates:
- Adjusted tests in ar-gateway and ar-orchestrator to verify the new behavior of accepting webhooks without dispatching reviews and using the CI endpoint for triggering reviews.

This PR modifies the review dispatch process to be CI-gated, stopping automatic dispatch from ordinary PR webhooks. It updates documentation and tests to reflect this change, ensuring that reviews are only triggered after CI prerequisites are met or through explicit commands. The changes appear well-implemented and safe to merge. ## Walkthrough - **Documentation Updates**: - Updated various markdown files to reflect the new CI-gated review process, ensuring users understand the new workflow. - Added instructions for setting up CI tokens and triggering reviews via CI workflows. - **Code Changes**: - Modified `ar-gateway` to accept PR webhooks without dispatching reviews, aligning with the new CI-gated process. - Updated `ar-chat` to include messages about bypassing CI gating for forced reviews. - **Test Updates**: - Adjusted tests in `ar-gateway` and `ar-orchestrator` to verify the new behavior of accepting webhooks without dispatching reviews and using the CI endpoint for triggering reviews.

jwilger merged commit d3ee9d4c6c into main

2026-05-04 12:20:49 -07:00

jwilger deleted branch fix/issue-44-ci-gated-reviews

2026-05-04 12:20:49 -07:00

jwilger referenced this pull request from a commit

2026-05-04 12:20:51 -07:00

fix(gateway): gate semantic reviews behind CI (#72)

jwilger referenced this pull request

2026-05-05 11:58:16 -07:00

chore: release v0.1.0 #94

jwilger referenced this pull request from a commit

2026-05-05 12:18:07 -07:00