fix(forgejo): use web compare diff route #73

Merged

jwilger merged 1 commit from fix/issue-71-incremental-compare-diff into main

2026-05-04 12:51:37 -07:00

jwilger commented

2026-05-04 12:46:16 -07:00

Owner

Summary

Fetch incremental compare diffs from Forgejo's web compare .diff route instead of appending .diff to the API compare endpoint.
Preserve full-diff fallback for real missing compare targets while warning on the old request-construction failure shape.
Add focused regressions for compare-diff URL construction and fallback log classification.

Verification

nix develop -c cargo nextest run -p ar-forgejo get_compare_diff
nix develop -c cargo nextest run -p ar-orchestrator compare_diff
nix develop -c cargo fmt --all -- --check
nix develop -c cargo nextest run -p ar-forgejo
nix develop -c cargo nextest run -p ar-orchestrator
nix develop -c cargo clippy --workspace --all-targets -- -D warnings

Closes #71.

## Summary - Fetch incremental compare diffs from Forgejo's web compare `.diff` route instead of appending `.diff` to the API compare endpoint. - Preserve full-diff fallback for real missing compare targets while warning on the old request-construction failure shape. - Add focused regressions for compare-diff URL construction and fallback log classification. ## Verification - `nix develop -c cargo nextest run -p ar-forgejo get_compare_diff` - `nix develop -c cargo nextest run -p ar-orchestrator compare_diff` - `nix develop -c cargo fmt --all -- --check` - `nix develop -c cargo nextest run -p ar-forgejo` - `nix develop -c cargo nextest run -p ar-orchestrator` - `nix develop -c cargo clippy --workspace --all-targets -- -D warnings` Closes #71.

jwilger added 1 commit

2026-05-04 12:46:16 -07:00

fix(forgejo): use web compare diff route

CI / Nix flake check (pull_request) Successful in 2m32s

Details

CI / auto_review semantic review (pull_request) Successful in 1s

Details

auto_review auto_review: no findings

6d3c3ae39b

auto-review approved these changes

2026-05-04 12:49:47 -07:00

auto-review left a comment

This PR updates the Forgejo client to use the web compare .diff route for fetching diffs, addressing issue #71. The changes appear safe to merge, with improved error handling and additional test coverage for URL construction and fallback behavior.

Walkthrough

CHANGELOG.md: Updated to reflect the change in how Forgejo compare diffs are fetched, closing issue #71.
crates/ar-forgejo/src/client.rs: Modified the URL construction for fetching diffs to use the web compare .diff route. Updated tests to reflect this change.
crates/ar-orchestrator/src/dispatcher.rs: Adjusted error handling logic to differentiate between old API construction bugs and legitimate missing targets, with corresponding test updates.

This PR updates the Forgejo client to use the web compare `.diff` route for fetching diffs, addressing issue #71. The changes appear safe to merge, with improved error handling and additional test coverage for URL construction and fallback behavior. ## Walkthrough - **CHANGELOG.md**: Updated to reflect the change in how Forgejo compare diffs are fetched, closing issue #71. - **crates/ar-forgejo/src/client.rs**: Modified the URL construction for fetching diffs to use the web compare `.diff` route. Updated tests to reflect this change. - **crates/ar-orchestrator/src/dispatcher.rs**: Adjusted error handling logic to differentiate between old API construction bugs and legitimate missing targets, with corresponding test updates.

jwilger merged commit f5eb3ed1a2 into main

2026-05-04 12:51:37 -07:00

jwilger deleted branch fix/issue-71-incremental-compare-diff

2026-05-04 12:51:37 -07:00

jwilger referenced this pull request from a commit

2026-05-04 12:51:38 -07:00

fix(forgejo): use web compare diff route (#73)

jwilger referenced this pull request

2026-05-05 11:58:16 -07:00

chore: release v0.1.0 #94

jwilger referenced this pull request from a commit

2026-05-05 12:18:07 -07:00