Slipstream/auto_review
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 27 Packages Activity Actions

fix(review): make incremental walkthroughs delta-focused #98

Merged
jwilger merged 1 commit from issue-14-incremental-walkthrough into main 2026-05-05 15:26:17 -07:00
Conversation 1 Commits 1 Files changed 14 +459 -11
jwilger commented 2026-05-05 15:17:53 -07:00
Owner
Copy link

Closes #14.

Summary

  • Trim redundant PR-description recap openings from posted review bodies and update prompt/schema guidance so summaries assess the review outcome instead of restating the PR.
  • Pass previous-review SHA context through orchestrated incremental reviews and scope walkthrough guidance to the compare diff.
  • Derive incremental prompt file context and final path guarding from compare-diff paths instead of stale full-PR file lists.

Verification

  • nix develop -c cargo fmt --all -- --check
  • nix develop -c cargo nextest run -p ar-prompts -p ar-review -p ar-orchestrator --no-tests=pass
  • nix develop -c cargo clippy -p ar-prompts -p ar-review -p ar-orchestrator -p ar-cli --all-targets -- -D warnings
  • git diff --check
Closes #14. ## Summary - Trim redundant PR-description recap openings from posted review bodies and update prompt/schema guidance so summaries assess the review outcome instead of restating the PR. - Pass previous-review SHA context through orchestrated incremental reviews and scope walkthrough guidance to the compare diff. - Derive incremental prompt file context and final path guarding from compare-diff paths instead of stale full-PR file lists. ## Verification - nix develop -c cargo fmt --all -- --check - nix develop -c cargo nextest run -p ar-prompts -p ar-review -p ar-orchestrator --no-tests=pass - nix develop -c cargo clippy -p ar-prompts -p ar-review -p ar-orchestrator -p ar-cli --all-targets -- -D warnings - git diff --check
fix(review): make incremental walkthroughs delta-focused
All checks were successful
CI / Nix flake check (pull_request) Successful in 2m38s
Details
CI / auto_review semantic review (pull_request) Successful in 1s
Details
auto_review auto_review: no findings
Publish release / release-publish (pull_request) Has been skipped
Details
2b4f278895
auto-review approved these changes 2026-05-05 15:20:55 -07:00
auto-review left a comment
Copy link

The PR refines the review process by focusing incremental walkthroughs on deltas and removing redundant PR recaps. It introduces the previous_review_sha to scope reviews and updates the prompt schema to avoid restating PR descriptions. The changes appear well-tested and safe to merge.

Walkthrough

  • crates/ar-cli/src/bench.rs and crates/ar-cli/src/commands.rs:
    • Added previous_review_sha to function calls, enhancing incremental review capabilities.
  • crates/ar-orchestrator/src/dispatcher.rs:
    • Updated run_review_job to include previous_review_sha, allowing for delta-focused reviews.
  • crates/ar-prompts/schemas/review.json and crates/ar-prompts/src/prompt.rs:
    • Modified the summary field to focus on review outcomes rather than restating PR descriptions.
    • Introduced previous_review_sha in ReviewPromptInputs for incremental review context.
  • crates/ar-review/src/pipeline.rs:
    • Adjusted ReviewArgs to include previous_review_sha, ensuring reviews are scoped to changes since the last review.
The PR refines the review process by focusing incremental walkthroughs on deltas and removing redundant PR recaps. It introduces the `previous_review_sha` to scope reviews and updates the prompt schema to avoid restating PR descriptions. The changes appear well-tested and safe to merge. ## Walkthrough - **crates/ar-cli/src/bench.rs** and **crates/ar-cli/src/commands.rs**: - Added `previous_review_sha` to function calls, enhancing incremental review capabilities. - **crates/ar-orchestrator/src/dispatcher.rs**: - Updated `run_review_job` to include `previous_review_sha`, allowing for delta-focused reviews. - **crates/ar-prompts/schemas/review.json** and **crates/ar-prompts/src/prompt.rs**: - Modified the `summary` field to focus on review outcomes rather than restating PR descriptions. - Introduced `previous_review_sha` in `ReviewPromptInputs` for incremental review context. - **crates/ar-review/src/pipeline.rs**: - Adjusted `ReviewArgs` to include `previous_review_sha`, ensuring reviews are scoped to changes since the last review.
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels   
bug

   
discussion

   
enhancement
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
discussion
enhancement
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/auto_review!98
No description provided.