Slipstream/emc
3
0
Fork 0
Code Issues Pull requests Releases 4 Activity Actions

fix: propagate release-plz signing config #110

Merged
jwilger merged 1 commit from fix/release-plz-signing-config into main 2026-06-11 19:53:26 -07:00
Conversation 1 Commits 1 Files changed 2 +5 -6
jwilger commented 2026-06-11 19:40:28 -07:00
Owner
Copy link

Summary

  • Export an explicit GIT_CONFIG_GLOBAL from the release-plz signing helper.
  • Configure the release-plz author in the same shell that runs release-plz after signing setup.

Rationale
Run #263 still produced an unverified release commit. release-plz creates commits from a temporary git directory under nix develop, so relying on the default HOME global config is not sufficient. Exporting GIT_CONFIG_GLOBAL keeps signing and author config visible to child git processes even if HOME changes.

Verification

  • actionlint .forgejo/workflows/release-plz.yml
  • sh -n .forgejo/scripts/configure-release-plz-git-signing.sh
  • generated throwaway SSH key, changed HOME after sourcing the helper, and verified git commit output contains a gpgsig SSH signature header
  • just copyright-headers
  • git diff --check
Summary - Export an explicit GIT_CONFIG_GLOBAL from the release-plz signing helper. - Configure the release-plz author in the same shell that runs release-plz after signing setup. Rationale Run #263 still produced an unverified release commit. release-plz creates commits from a temporary git directory under nix develop, so relying on the default HOME global config is not sufficient. Exporting GIT_CONFIG_GLOBAL keeps signing and author config visible to child git processes even if HOME changes. Verification - actionlint .forgejo/workflows/release-plz.yml - sh -n .forgejo/scripts/configure-release-plz-git-signing.sh - generated throwaway SSH key, changed HOME after sourcing the helper, and verified git commit output contains a gpgsig SSH signature header - just copyright-headers - git diff --check
fix: propagate release-plz signing config
All checks were successful
CI / Nix flake check (pull_request) Successful in 2m28s
Details
CI / Request auto_review semantic review (pull_request) Successful in 2s
Details
auto_review auto_review: no findings
CI / Rust CI (pull_request) Successful in 12m25s
Details
f1e00b15c4
auto-review approved these changes 2026-06-11 19:50:50 -07:00
auto-review left a comment
Copy link

The PR improves the release-plz signing configuration by exporting GIT_CONFIG_GLOBAL and consolidating author configuration into the same shell as the release-plz command. These changes should ensure that the signing and author configurations are consistently applied, even if the HOME directory changes.

Walkthrough

  • .forgejo/scripts/configure-release-plz-git-signing.sh
    • Introduced GIT_CONFIG_GLOBAL to ensure signing configuration is maintained across git processes.
  • .forgejo/workflows/release-plz.yml
    • Moved the author configuration into the same shell as the release-plz command to ensure it is applied correctly.

LLM usage and cost

The PR improves the release-plz signing configuration by exporting `GIT_CONFIG_GLOBAL` and consolidating author configuration into the same shell as the release-plz command. These changes should ensure that the signing and author configurations are consistently applied, even if the HOME directory changes. ## Walkthrough - **.forgejo/scripts/configure-release-plz-git-signing.sh** - Introduced `GIT_CONFIG_GLOBAL` to ensure signing configuration is maintained across git processes. - **.forgejo/workflows/release-plz.yml** - Moved the author configuration into the same shell as the release-plz command to ensure it is applied correctly. ## LLM usage and cost - Reasoning (gpt-4o) in=1439 out=303 cost=$0.011740 - Cheap (gpt-4o-mini) in=440 out=48 cost=$0.000095 Estimated total USD: $0.011835 via https://api.openai.com and https://api.openai.com
Sign in to join this conversation.
Reviewers
No reviewers
auto-review
Labels
Clear labels
  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Slipstream/emc!110
No description provided.