ci: skip auto_review metadata gate for automated release PRs #125

Merged

jwilger merged 1 commit from fix/skip-auto-review-on-release-prs into main

2026-06-13 21:37:39 -07:00

jwilger commented

2026-06-13 21:27:51 -07:00

Owner

Summary

Stop the auto_review "PR metadata quality" gate from blocking automated
release PRs, while leaving feature PRs fully reviewed.

Rationale

The auto_review gate is tuned for feature PRs. On automated release PRs (a
mechanical version bump + changelog regeneration) it issued contradictory
metadata-quality rationales run-to-run — first demanding a description after the
version, then rejecting that description for not being "concise", etc. — so no
generated release title could satisfy it and every release was blocked.

Branch protection requires the auto_review and CI / Request auto_review semantic review status checks, so the job cannot simply be skipped (the
required checks would hang). Instead, for release-plz-* head branches this:

skips the gateway request, and
self-reports the required auto_review status as success

so all required status checks pass. Branch protection still requires one
approval, so a human approves the release PR — but without fighting the gate.

Feature PRs are unchanged: IS_RELEASE_PR is false, so the original
gateway-request flow runs exactly as before (this PR itself is reviewed
normally).

Verification

scripts/copyright-headers.sh --check passes.
This PR exercises the unchanged feature-PR path (auto_review reviews it). The
release-PR path will be exercised by the next release PR.

🤖 Generated with Claude Code

## Summary Stop the `auto_review` "PR metadata quality" gate from blocking automated release PRs, while leaving feature PRs fully reviewed. ## Rationale The auto_review gate is tuned for feature PRs. On automated release PRs (a mechanical version bump + changelog regeneration) it issued contradictory metadata-quality rationales run-to-run — first demanding a description after the version, then rejecting that description for not being "concise", etc. — so no generated release title could satisfy it and every release was blocked. Branch protection requires the `auto_review` and `CI / Request auto_review semantic review` status checks, so the job cannot simply be skipped (the required checks would hang). Instead, for `release-plz-*` head branches this: - skips the gateway request, and - self-reports the required `auto_review` status as `success` so all required status checks pass. Branch protection still requires one approval, so a human approves the release PR — but without fighting the gate. Feature PRs are unchanged: `IS_RELEASE_PR` is false, so the original gateway-request flow runs exactly as before (this PR itself is reviewed normally). ## Verification - `scripts/copyright-headers.sh --check` passes. - This PR exercises the unchanged feature-PR path (auto_review reviews it). The release-PR path will be exercised by the next release PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

jwilger added 1 commit

2026-06-13 21:27:51 -07:00

ci: skip auto_review metadata gate for automated release PRs

CI / Nix flake check (pull_request) Successful in 2m13s

Details

CI / Request auto_review semantic review (pull_request) Successful in 2s

Details

auto_review auto_review: no findings

CI / Rust CI (pull_request) Successful in 8m55s

Details

e41e609cf3

The auto_review "PR metadata quality" gate is tuned for feature PRs and
repeatedly rejected automated release PR titles with contradictory rationales
(it wanted a description, then conciseness, etc.), blocking every release.
release PRs (version bump + changelog) are mechanical, so skip the semantic
review for `release-plz-*` head branches and self-report the
branch-protection-required `auto_review` status as success. Feature PRs are
unaffected (IS_RELEASE_PR is false). A human still approves the release PR
(branch protection requires one approval).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

auto-review approved these changes

2026-06-13 21:30:11 -07:00

auto-review left a comment

The PR modifies the CI workflow to bypass the auto_review gate for automated release PRs, addressing issues with contradictory metadata checks. The change appears safe to merge as it maintains the original behavior for feature PRs.

Walkthrough

CI Workflow Changes:
- Introduced a new environment variable IS_RELEASE_PR to identify release PRs based on the branch name.
- Added a step to self-report the auto_review status as success for release PRs, ensuring required status checks pass without manual intervention.
- Adjusted conditions for existing steps to exclude release PRs from the auto_review process.
- These changes ensure that automated release PRs are not blocked by the auto_review gate, while feature PRs continue to be reviewed as before.

LLM usage and cost

Reasoning (gpt-4o) in=1799 out=301 cost=$0.013510
Cheap (gpt-4o-mini) in=586 out=44 cost=$0.000114
Estimated total USD: $0.013624 via https://api.openai.com and https://api.openai.com

The PR modifies the CI workflow to bypass the `auto_review` gate for automated release PRs, addressing issues with contradictory metadata checks. The change appears safe to merge as it maintains the original behavior for feature PRs. ## Walkthrough - **CI Workflow Changes**: - Introduced a new environment variable `IS_RELEASE_PR` to identify release PRs based on the branch name. - Added a step to self-report the `auto_review` status as `success` for release PRs, ensuring required status checks pass without manual intervention. - Adjusted conditions for existing steps to exclude release PRs from the `auto_review` process. - These changes ensure that automated release PRs are not blocked by the `auto_review` gate, while feature PRs continue to be reviewed as before. ## LLM usage and cost - Reasoning (gpt-4o) in=1799 out=301 cost=$0.013510 - Cheap (gpt-4o-mini) in=586 out=44 cost=$0.000114 Estimated total USD: $0.013624 via https://api.openai.com and https://api.openai.com

jwilger merged commit 623dc59781 into main

2026-06-13 21:37:39 -07:00

jwilger deleted branch fix/skip-auto-review-on-release-prs

2026-06-13 21:37:39 -07:00

jwilger referenced this pull request from a commit

2026-06-13 21:37:40 -07:00

ci: skip auto_review metadata gate for automated release PRs (#125)