fix(post): default AR_SEVERITY_FLOOR to warning (#6) #17

Merged

jwilger merged 1 commit from fix/severity-floor-default-warning into main

2026-05-01 15:27:33 -07:00

jwilger commented

2026-05-01 15:23:44 -07:00

Owner

Summary

Default AR_SEVERITY_FLOOR flips from note to warning. Notes are LLM scratchpad — useful inside the pipeline (the schema keeps them and the LLM can still emit them) but pure noise on the PR page once the verifier has run. PR #4 surfaced 16 LGTM-style notes across 3 review cycles.
parse_severity_floor extracted from severity_floor_from_env so the value matrix unit-tests without touching std::env.
Unrecognised values now fall through to warning instead of note, with a warn log; a typo no longer silently inverts the operator's signal-to-noise expectation.
Docs synced: docs/OPERATIONS.md §7.2.5, QUICKSTART.md env table, deploy/systemd/auto_review.env.example, deploy/helm/values.yaml. CHANGELOG ### Changed entry added.

Closes #6.

Test plan

cargo test -p ar-orchestrator — 38 passed (5 new severity-floor cases)
cargo clippy --workspace --all-targets -- -D warnings clean
cargo fmt --all -- --check clean
Operators who relied on the old note default: set AR_SEVERITY_FLOOR=note in env to restore previous posting behaviour

## Summary - Default `AR_SEVERITY_FLOOR` flips from `note` to `warning`. Notes are LLM scratchpad — useful inside the pipeline (the schema keeps them and the LLM can still emit them) but pure noise on the PR page once the verifier has run. PR #4 surfaced 16 LGTM-style notes across 3 review cycles. - `parse_severity_floor` extracted from `severity_floor_from_env` so the value matrix unit-tests without touching `std::env`. - Unrecognised values now fall through to `warning` instead of `note`, with a warn log; a typo no longer silently inverts the operator's signal-to-noise expectation. - Docs synced: `docs/OPERATIONS.md` §7.2.5, `QUICKSTART.md` env table, `deploy/systemd/auto_review.env.example`, `deploy/helm/values.yaml`. CHANGELOG `### Changed` entry added. Closes #6. ## Test plan - [x] `cargo test -p ar-orchestrator` — 38 passed (5 new severity-floor cases) - [x] `cargo clippy --workspace --all-targets -- -D warnings` clean - [x] `cargo fmt --all -- --check` clean - [ ] Operators who relied on the old `note` default: set `AR_SEVERITY_FLOOR=note` in env to restore previous posting behaviour

jwilger added 1 commit

2026-05-01 15:23:44 -07:00

fix(post): default AR_SEVERITY_FLOOR to warning (#6 )

auto_review auto_review: 6 notes

CI / Nix flake check (pull_request) Successful in 1m41s

Details

455176e171

Notes function as the LLM's reasoning scratchpad during a review
pass — externalising observations about the diff makes the review
more thorough — but they're pure noise on the PR page once the
verifier has finished. PR #4 surfaced 16 LGTM-style notes ("💡
Note: switching from find() to match_indices()...") across three
review cycles, drowning the substantive findings.

The note tier stays in the schema (the LLM can still emit them);
the post step drops them by default. Operators who want notes on
the PR set AR_SEVERITY_FLOOR=note explicitly. Unrecognised
spellings now also fall through to the default (warning) rather
than note, so a typo doesn't silently invert the operator's
signal-to-noise expectation.

Refactored severity_floor_from_env into a pure parser
(parse_severity_floor) so the matrix of values can be unit-tested
without touching std::env (process-global state, racy under
parallel tests).

auto-review reviewed

2026-05-01 15:24:42 -07:00

auto-review left a comment

This PR changes the default AR_SEVERITY_FLOOR from note to warning, reducing noise on PR pages by default. The change is well-documented across the codebase, and tests have been added to ensure the new behavior is correctly implemented. The PR appears safe to merge, but users relying on the previous default should be informed.

Walkthrough

CHANGELOG.md: Updated to reflect the change in default behavior for AR_SEVERITY_FLOOR.
QUICKSTART.md: Updated the default value for AR_SEVERITY_FLOOR to warning.
dispatcher.rs: Extracted parse_severity_floor function to handle parsing and defaulting logic. Added tests to verify the new default behavior.
Helm and systemd configurations: Updated to reflect the new default for AR_SEVERITY_FLOOR.
OPERATIONS.md: Updated documentation to explain the new default behavior and its implications.

Pre-merge checks

CHANGELOG updated — CHANGELOG.md is in the diff
Tests touched — source changed but no test file appears in the diff
No new TODO/FIXME comments — no new TODO/FIXME markers

This PR changes the default `AR_SEVERITY_FLOOR` from `note` to `warning`, reducing noise on PR pages by default. The change is well-documented across the codebase, and tests have been added to ensure the new behavior is correctly implemented. The PR appears safe to merge, but users relying on the previous default should be informed. ## Walkthrough - **CHANGELOG.md**: Updated to reflect the change in default behavior for `AR_SEVERITY_FLOOR`. - **QUICKSTART.md**: Updated the default value for `AR_SEVERITY_FLOOR` to `warning`. - **dispatcher.rs**: Extracted `parse_severity_floor` function to handle parsing and defaulting logic. Added tests to verify the new default behavior. - **Helm and systemd configurations**: Updated to reflect the new default for `AR_SEVERITY_FLOOR`. - **OPERATIONS.md**: Updated documentation to explain the new default behavior and its implications. ## Pre-merge checks - [x] CHANGELOG updated — CHANGELOG.md is in the diff - [x] Tests touched — source changed but no test file appears in the diff - [x] No new TODO/FIXME comments — no new TODO/FIXME markers

QUICKSTART.md

💡 Note: The default value for AR_SEVERITY_FLOOR has been updated to warning. Ensure that this change is communicated to users who might rely on the previous default of note.

💡 **Note:** The default value for `AR_SEVERITY_FLOOR` has been updated to `warning`. Ensure that this change is communicated to users who might rely on the previous default of `note`.